From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD69C36008 for ; Wed, 26 Mar 2025 22:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WpQRiPMWre5w+oBe5t52C7npv5APr1INrJO/mypsiTE=; b=kHiRTQEADiSFrLvcYZEvBuV8sD 18lQxq8fKQE05s/QWupm/L8/TrWc6GsKr13wIkqNrgePF41fyGZ1WkT4oS3wzzjZq9xS/H8s3Hsuz Ag5OhFAPLHJD3+xINLvdfodninckChvBw/yEFREUh/EUhBlLs7E+vEusItyXN9JmeO/ifqrq29UmR CwyrzE8oMi7FTkeTG/+pSqdmthsqfBIbIGxVJGWEaXft+W1qUfbA1dyulrlanhw8toce2gP04iP6s iTJyX1OgjBA08poKupkuyJYH+uQ6/M2HxciIruETfVPHiZ8Sspn+DfrzwD7Zzx/kF5z6o90QC40BX oByj26iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txZWW-00000009jh5-30ak; Wed, 26 Mar 2025 22:47:00 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txZWU-00000009jgI-3MXt for kexec@lists.infradead.org; Wed, 26 Mar 2025 22:46:59 +0000 Received: from [10.17.64.132] (unknown [131.107.147.132]) by linux.microsoft.com (Postfix) with ESMTPSA id 0EFD4210235E; Wed, 26 Mar 2025 15:46:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0EFD4210235E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1743029217; bh=WpQRiPMWre5w+oBe5t52C7npv5APr1INrJO/mypsiTE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sKgV6M9wLQw9WiOTCQUm1nhq24BoZZcDn4uhQq9k6apxualjEFDdcPOgCFCoz572i ciFXzhFzDl/Cyy2JIVFr2Z9s8ffkrWtdsNDF/CSiODCu6HqGrq3dMBIDm8fz/T4P+j snRRve0tkABnzrVk+X1KBYQKlJSd7CM9tW3yEt/w= Message-ID: <2d2ea573-1ddd-44b4-8ba3-4ae86313d63f@linux.microsoft.com> Date: Wed, 26 Mar 2025 15:46:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 6/8] ima: kexec: move IMA log copy from kexec load to execute To: Baoquan He Cc: zohar@linux.ibm.com, stefanb@linux.ibm.com, roberto.sassu@huaweicloud.com, roberto.sassu@huawei.com, eric.snowberg@oracle.com, ebiederm@xmission.com, paul@paul-moore.com, code@tyhicks.com, bauermann@kolabnow.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com, nramas@linux.microsoft.com, James.Bottomley@hansenpartnership.com, vgoyal@redhat.com, dyoung@redhat.com References: <20250318010448.954-1-chenste@linux.microsoft.com> <20250318010448.954-7-chenste@linux.microsoft.com> <3d7b5e06-5166-46bb-89dc-a0b95ca7c767@linux.microsoft.com> <6583378c-55ee-4192-a95f-ebaf3f708bbb@linux.microsoft.com> Content-Language: en-US From: steven chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250326_154658_901534_2FAAB548 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 3/25/2025 7:27 PM, Baoquan He wrote: > On 03/25/25 at 03:27pm, steven chen wrote: >> On 3/24/2025 4:00 AM, Baoquan He wrote: >>> On 03/21/25 at 09:23am, steven chen wrote: >>>> On 3/19/2025 7:06 PM, Baoquan He wrote: >>>>> On 03/17/25 at 06:04pm, steven chen wrote: >>>>> ...snip... >>>>>> --- >>>>>> kernel/kexec_file.c | 10 ++++++ >>>>>> security/integrity/ima/ima_kexec.c | 51 ++++++++++++++++++------------ >>>>>> 2 files changed, 40 insertions(+), 21 deletions(-) >>>>>> >>>>>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c >>>>>> index 606132253c79..ab449b43aaee 100644 >>>>>> --- a/kernel/kexec_file.c >>>>>> +++ b/kernel/kexec_file.c >>>>>> @@ -201,6 +201,13 @@ kimage_validate_signature(struct kimage *image) >>>>>> } >>>>>> #endif >>>>>> +static void kimage_file_post_load(struct kimage *image) >>>>>> +{ >>>>>> +#ifdef CONFIG_IMA_KEXEC >>>>>> + ima_kexec_post_load(image); >>>>>> +#endif >>>>>> +} >>>>>> + >>>>>> /* >>>>>> * In file mode list of segments is prepared by kernel. Copy relevant >>>>>> * data from user space, do error checking, prepare segment list >>>>>> @@ -428,6 +435,9 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, >>>>>> kimage_terminate(image); >>>>>> + if (!(flags & KEXEC_FILE_ON_CRASH)) >>>>>> + kimage_file_post_load(image); >>>>> machine_kexec_post_load() is called by both kexec_load and kexec_file_load, >>>>> we should use it to do things post load, but not introducing another >>>>> kimage_file_post_load(). >>>> Hi Baoquan, >>>> >>>> Could you give me more detail about this? >>> I mean machine_kexec_post_load() is the place where post load operations >>> are done, including kexec_load and kexec_file_load. There's no need to >>> specifically introduce a kimage_file_post_load() to do post load >>> operaton for kexec_file_load. >> Hi Baoquan, >> >> Updating the machine_kexec_post_load() API to carry flags would indeed >> require changes to multiple files. This approach involves the condition >> check if (!(flags & KEXEC_FILE_ON_CRASH)) and ensuring that the flags are >> properly passed and handled across the relevant file >> >> if just adding a API kimage_file_post_load() here, it is much easy and >> clean, right? > Hmm, it's easier, while maybe not good. We should not repeatedly > introduce similar things into codes. Here, it's similar as > what kexec_apply_relocations() and arch_kexec_apply_relocations() are > doing. > > int machine_kexec_post_load(struct kimage *image) > { > #ifdef CONFIG_IMA_KEXEC > ima_kexec_post_load(image); > #endif > return arch_machine_kexec_post_load(); > } > > Then a generic arch_machine_kexec_post_load(struct kimage *image) > {return 0;} version, and a arm64 specific version. > > Is it OK to you? Hi Baoquan, Thanks for your suggestion. I will update in the next version. Steven