From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH v3 09/17] arm64, trans_pgd: add trans_pgd_create_empty References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-10-pasha.tatashin@soleen.com> From: James Morse Message-ID: <2d9f7511-ce65-d5ca-653e-f4d43994a32d@arm.com> Date: Fri, 6 Sep 2019 16:20:26 +0100 MIME-Version: 1.0 In-Reply-To: <20190821183204.23576-10-pasha.tatashin@soleen.com> Content-Language: en-GB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pavel Tatashin Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jmorris@namei.org, linux-mm@kvack.org, ebiederm@xmission.com, matthias.bgg@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Hi Pavel, On 21/08/2019 19:31, Pavel Tatashin wrote: > This functions returns a zeroed trans_pgd using the allocator that is > specified in the info argument. > > trans_pgds should be created by using this function. This function takes the allocator you give it, and calls it once. Given both users need one pgd, and have to provide the allocator, it seems strange that they aren't trusted to call it. I don't think this patch is necessary. Let the caller pass in the pgd_t to the helpers. Thanks, James _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec