From: Benjamin Kay <benjamin@benkay.net>
To: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec: Fix callback parameter types
Date: Tue, 29 Jul 2014 13:18:11 -0400 [thread overview]
Message-ID: <30581068.8nhrM5BQlL@samoflange> (raw)
In-Reply-To: <20140729154001.Sx1ujgo15C8oflxb@hankala.org>
Thanks, this was causing kexec to refuse to load a crash kernel on my i686
system.
On Tuesday, July 29, 2014 15:51:03 Visa Hankala wrote:
> Commit 4362bfaca4d8d2a4380532880f0d08c2bf14184e changed
> kexec_iomem_for_each_line() to pass 'base' and 'length' parameters of
> the callback function as unsigned long long integers instead of unsigned
> longs. Some of the functions were not updated. This patch corrects the
> remaining instances.
>
> Signed-off-by: Visa Hankala <visa@hankala.org>
> ---
> kexec/arch/i386/crashdump-x86.c | 4 ++--
> kexec/arch/sh/crashdump-sh.c | 4 ++--
> kexec/arch/sh/kexec-sh.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kexec/arch/i386/crashdump-x86.c
> b/kexec/arch/i386/crashdump-x86.c index 77bdad5..82bf239 100644
> --- a/kexec/arch/i386/crashdump-x86.c
> +++ b/kexec/arch/i386/crashdump-x86.c
> @@ -1041,8 +1041,8 @@ int get_max_crash_kernel_limit(uint64_t *start,
> uint64_t *end)
>
> static int crashkernel_mem_callback(void *UNUSED(data), int nr,
> char *UNUSED(str),
> - unsigned long base,
> - unsigned long length)
> + unsigned long long base,
> + unsigned long long length)
> {
> if (nr >= CRASH_RESERVED_MEM_NR)
> return 1;
> diff --git a/kexec/arch/sh/crashdump-sh.c b/kexec/arch/sh/crashdump-sh.c
> index fe11b17..9e6af6b 100644
> --- a/kexec/arch/sh/crashdump-sh.c
> +++ b/kexec/arch/sh/crashdump-sh.c
> @@ -34,8 +34,8 @@ static struct memory_range
> crash_memory_range[CRASH_MAX_MEMORY_RANGES]; static int crash_sh_range_nr;
> static int crash_sh_memory_range_callback(void *UNUSED(data), int
> UNUSED(nr), char *str,
> - unsigned long base,
> - unsigned long length)
> + unsigned long long base,
> + unsigned long long length)
> {
>
> struct memory_range *range = crash_memory_range;
> diff --git a/kexec/arch/sh/kexec-sh.c b/kexec/arch/sh/kexec-sh.c
> index aea5dfb..ce341c8 100644
> --- a/kexec/arch/sh/kexec-sh.c
> +++ b/kexec/arch/sh/kexec-sh.c
> @@ -24,8 +24,8 @@ static struct memory_range
> memory_range[MAX_MEMORY_RANGES];
>
> static int kexec_sh_memory_range_callback(void *UNUSED(data), int nr,
> char *UNUSED(str),
> - unsigned long base,
> - unsigned long length)
> + unsigned long long base,
> + unsigned long long length)
> {
> if (nr < MAX_MEMORY_RANGES) {
> memory_range[nr].start = base;
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2014-07-29 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 15:51 [PATCH] kexec: Fix callback parameter types Visa Hankala
2014-07-29 17:18 ` Benjamin Kay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30581068.8nhrM5BQlL@samoflange \
--to=benjamin@benkay.net \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox