From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: kexec@lists.infradead.org,
xen-ia64-devel <xen-ia64-devel@lists.xensource.com>
Cc: Simon Horman <horms@verge.net.au>
Subject: [Patch] Fix PA() in purgatory-ia64.c
Date: Fri, 09 Nov 2007 18:34:11 +0900 [thread overview]
Message-ID: <3FC822B3AF3FCDtakebe_akio@jp.fujitsu.com> (raw)
Hi,
I met the issue that kdump didn't work on Xen/HVM guest.
I investigated the cause, found that PA() in purgatory-ia64.c
is used in Physical mode.
The PA() currently use PAGE_OFFSET fixed size(0xe000000000000000UL).
So the PA() don't work properly if it is called in Physcal mode.
inline unsigned long PA(unsigned long addr)
{
return addr - PAGE_OFFSET;
}
I make the patch to fix this issue.
How about this?
Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>
Best Regards,
Akio Takebe
---
--- kexec-tools-testing-20071030.orig/purgatory/arch/ia64/purgatory-ia64.c 2007-10-17 12:16:16.000000000 +0900
+++ kexec-tools-testing-20071030/purgatory/arch/ia64/purgatory-ia64.c 2007-11-09 18:20:27.000000000 +0900
@@ -21,7 +21,7 @@
#include <string.h>
#include "purgatory-ia64.h"
-#define PAGE_OFFSET 0xe000000000000000UL
+#define RGN_MASK 0xf000000000000000UL
#define EFI_PAGE_SHIFT 12
#define EFI_PAGE_SIZE (1UL<<EFI_PAGE_SHIFT)
@@ -147,7 +147,7 @@ setup_arch(void)
inline unsigned long PA(unsigned long addr)
{
- return addr - PAGE_OFFSET;
+ return addr|~RGN_MASK;
}
void
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
reply other threads:[~2007-11-09 9:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FC822B3AF3FCDtakebe_akio@jp.fujitsu.com \
--to=takebe_akio@jp.fujitsu.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=xen-ia64-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox