Re: [Crash-utility][PATCH V4 1/9] Add RISCV64 framework code support

From: "HAGIO KAZUHITO(萩尾　一仁)" <k-hagio-ab@nec.com>
To: Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"hschauhan@nulltrace.org" <hschauhan@nulltrace.org>,
	"lifang_xia@linux.alibaba.com" <lifang_xia@linux.alibaba.com>,
	"crash-utility@redhat.com" <crash-utility@redhat.com>,
	"mick@ics.forth.gr" <mick@ics.forth.gr>,
	"heinrich.schuchardt@canonical.com"
	<heinrich.schuchardt@canonical.com>,
	"guoren@kernel.org" <guoren@kernel.org>,
	"yixun.lan@gmail.com" <yixun.lan@gmail.com>,
	"lijiang@redhat.com" <lijiang@redhat.com>
Subject: Re: [Crash-utility][PATCH V4 1/9] Add RISCV64 framework code support
Date: Fri, 21 Oct 2022 02:17:02 +0000	[thread overview]
Message-ID: <4022d4a1-8967-3d09-e158-5a6f78f73655@nec.com> (raw)
In-Reply-To: <20221020015014.46085-2-xianting.tian@linux.alibaba.com>

On 2022/10/20 10:50, Xianting Tian wrote:

> diff --git a/README b/README
> index 5abbce1..d589e72 100644
> --- a/README
> +++ b/README
> @@ -37,7 +37,7 @@
>     These are the current prerequisites:
>   
>     o  At this point, x86, ia64, x86_64, ppc64, ppc, arm, arm64, alpha, mips,
> -     mips64, s390 and s390x-based kernels are supported.  Other architectures
> +     mips64, riscv64, s390 and s390x-based kernels are supported.  Other architectures
>        may be addressed in the future.

Sentences in the README are wrapped within 80 characters, I will change
this to:

+     mips64, riscv64, s390 and s390x-based kernels are supported.  Other
+     architectures may be addressed in the future.

>   
>     o  One size fits all -- the utility can be run on any Linux kernel version
> @@ -98,6 +98,8 @@
>        arm64 dumpfiles may be built by typing "make target=ARM64".
>     o  On an x86_64 host, an x86_64 binary that can be used to analyze
>        ppc64le dumpfiles may be built by typing "make target=PPC64".
> +  o  On an x86_64 host, an x86_64 binary that can be used to analyze
> +     riscv64 dumpfiles may be built by typing "make target=RISCV64".
>   
>     Traditionally when vmcores are compressed via the makedumpfile(8) facility
>     the libz compression library is used, and by default the crash utility


> diff --git a/help.c b/help.c
> index 99214c1..253c71b 100644
> --- a/help.c
> +++ b/help.c
> @@ -9512,7 +9512,7 @@ char *README[] = {
>   "  These are the current prerequisites: ",
>   "",
>   "  o  At this point, x86, ia64, x86_64, ppc64, ppc, arm, arm64, alpha, mips,",
> -"     mips64, s390 and s390x-based kernels are supported.  Other architectures",
> +"     mips64, riscv64, s390 and s390x-based kernels are supported.  Other architectures",
>   "     may be addressed in the future.",
>   "",
>   "  o  One size fits all -- the utility can be run on any Linux kernel version",

Same as above.

And help.c lacks this part, will add:

@@ -9572,6 +9572,8 @@ README_ENTER_DIRECTORY,
  "     arm64 dumpfiles may be built by typing \"make target=ARM64\".",
  "  o  On an x86_64 host, an x86_64 binary that can be used to analyze",
  "     ppc64le dumpfiles may be built by typing \"make target=PPC64\".",
+"  o  On an x86_64 host, an x86_64 binary that can be used to analyze",
+"     riscv64 dumpfiles may be built by typing \"make target=RISCV64\".",
  "",
  "  Traditionally when vmcores are compressed via the makedumpfile(8) facility",
  "  the libz compression library is used, and by default the crash utility",


With these, the v4 crash patch set looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab@nec.com>

Thanks,
Kazu
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
