From: Kairui Song <kasong@redhat.com>
To: Federico Pellegrin <fede@evolware.org>, kexec@lists.infradead.org
Subject: Re: [PATCH 1/1] kexec-tools: fix build on pre 4.4 kernels
Date: Tue, 23 Feb 2021 18:32:39 +0800 [thread overview]
Message-ID: <4501fa78-355d-eb7c-69c4-5665620aa1a1@redhat.com> (raw)
In-Reply-To: <20210205081559.15956-1-fede@evolware.org>
On 2/5/21 4:15 PM, Federico Pellegrin wrote:
> kexec build will fail on older kernels (pre 4.4) as the define
> VIDEO_CAPABILITY_64BIT_BASE was not present at that time.
>
> This patch adds it, as per linux/include/uapi/linux/screen_info.h,
> if not present.
>
> Signed-off-by: Federico Pellegrin <fede@evolware.org>
> ---
> kexec/arch/i386/x86-linux-setup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
> index 76e1185..ab54a4a 100644
> --- a/kexec/arch/i386/x86-linux-setup.c
> +++ b/kexec/arch/i386/x86-linux-setup.c
> @@ -37,6 +37,10 @@
> #include "x86-linux-setup.h"
> #include "../../kexec/kexec-syscall.h"
>
> +#ifndef VIDEO_CAPABILITY_64BIT_BASE
> +#define VIDEO_CAPABILITY_64BIT_BASE (1 << 1) /* Frame buffer base is 64-bit */
> +#endif
> +
> void init_linux_parameters(struct x86_linux_param_header *real_mode)
> {
> /* Fill in the values that are usually provided by the kernel. */
Thanks for the fix, I didn't notice pre 4.4 kernels don't have this defined
when I submitted that patch.
Reviewed-by: Kairui Song <kasong@redhat.com>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-02-23 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 8:15 [PATCH 1/1] kexec-tools: fix build on pre 4.4 kernels Federico Pellegrin
2021-02-07 8:00 ` Dave Young
2021-02-19 4:29 ` Federico Pellegrin
2021-02-23 10:32 ` Kairui Song [this message]
2021-03-11 7:25 ` Federico Pellegrin
2021-04-02 9:53 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4501fa78-355d-eb7c-69c4-5665620aa1a1@redhat.com \
--to=kasong@redhat.com \
--cc=fede@evolware.org \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox