From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: kexec@lists.infradead.org
Subject: [patch v3] kexec fix ppc64 device-tree mem node
Date: Wed, 09 May 2007 15:35:19 -0700 [thread overview]
Message-ID: <46424CA7.8060204@am.sony.com> (raw)
In-Reply-To: <46413472.8000304@am.sony.com>
Subject: kexec fix ppc64 device-tree mem node
Change the ppc64 device-tree memory node name spec to match the allowable names
specified in the booting-without-of document.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Version 2, Changed to look for 'memory', or 'memory@' nodes.
Version 3, Fixed missing 'if' in get_base_ranges().
kexec/arch/ppc64/crashdump-ppc64.c | 3 ++-
kexec/arch/ppc64/kexec-ppc64.c | 14 +++++++++-----
2 files changed, 11 insertions(+), 6 deletions(-)
--- ps3-kexec-tools.orig/kexec/arch/ppc64/crashdump-ppc64.c
+++ ps3-kexec-tools/kexec/arch/ppc64/crashdump-ppc64.c
@@ -129,7 +129,8 @@ static int get_crash_memory_ranges(struc
goto err;
}
while ((dentry = readdir(dir)) != NULL) {
- if (strncmp(dentry->d_name, "memory@", 7))
+ if (strncmp(dentry->d_name, "memory@", 7) &&
+ strcmp(dentry->d_name, "memory"))
continue;
strcpy(fname, device_tree);
strcat(fname, dentry->d_name);
--- ps3-kexec-tools.orig/kexec/arch/ppc64/kexec-ppc64.c
+++ ps3-kexec-tools/kexec/arch/ppc64/kexec-ppc64.c
@@ -98,7 +98,7 @@ err1:
}
/*
- * Count the memory@ nodes under /proc/device-tree and populate the
+ * Count the memory nodes under /proc/device-tree and populate the
* max_memory_ranges variable. This variable replaces MAX_MEMORY_RANGES
* macro used earlier.
*/
@@ -115,7 +115,8 @@ static int count_memory_ranges(void)
while ((dentry = readdir(dir)) != NULL) {
if (strncmp(dentry->d_name, "memory@", 7) &&
- strncmp(dentry->d_name, "pci@", 4))
+ strcmp(dentry->d_name, "memory") &&
+ strncmp(dentry->d_name, "pci@", 4))
continue;
max_memory_ranges++;
}
@@ -170,7 +171,8 @@ static int get_base_ranges(void)
return -1;
}
while ((dentry = readdir(dir)) != NULL) {
- if (strncmp(dentry->d_name, "memory@", 7))
+ if (strncmp(dentry->d_name, "memory@", 7) &&
+ strcmp(dentry->d_name, "memory"))
continue;
strcpy(fname, device_tree);
strcat(fname, dentry->d_name);
@@ -272,7 +274,8 @@ static int get_devtree_details(unsigned
while ((dentry = readdir(dir)) != NULL) {
if (strncmp(dentry->d_name, "chosen", 6) &&
- strncmp(dentry->d_name, "memory@0", 8) &&
+ strncmp(dentry->d_name, "memory@", 7) &&
+ strcmp(dentry->d_name, "memory") &&
strncmp(dentry->d_name, "pci@", 4) &&
strncmp(dentry->d_name, "rtas", 4))
continue;
@@ -452,7 +455,8 @@ static int get_devtree_details(unsigned
add_usable_mem_rgns(rtas_base, rtas_size);
} /* rtas */
- if (strncmp(dentry->d_name, "memory@0", 8) == 0) {
+ if (!strncmp(dentry->d_name, "memory@", 7) ||
+ !strcmp(dentry->d_name, "memory")) {
strcat(fname, "/reg");
if ((file = fopen(fname, "r")) == NULL) {
perror(fname);
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2007-05-09 22:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070507235727.631477448@am.sony.com>
2007-05-08 0:02 ` [patch 1/5] kexec debug output improvments Geoff Levand
2007-05-08 6:08 ` Simon Horman
2007-05-08 14:40 ` Geoff Levand
2007-05-09 6:47 ` Simon Horman
2007-05-08 6:12 ` use dprintf Simon Horman
2007-05-09 21:40 ` [patch 1/2] kexec remove last remaining dfprintf Geoff Levand
2007-05-10 2:13 ` Simon Horman
2007-05-10 2:55 ` Simon Horman
2007-05-09 21:40 ` [patch 2/2] kexec rename dprintf to dbgprintf Geoff Levand
2007-05-10 2:14 ` Simon Horman
2007-05-10 2:55 ` Simon Horman
2007-05-10 22:10 ` kexec and kdb Preetesh Parekh
2007-05-11 4:23 ` Vivek Goyal
2007-05-14 23:20 ` Preetesh Parekh
2007-05-15 7:54 ` Vivek Goyal
2007-05-16 17:45 ` Preetesh Parekh
2007-05-08 6:20 ` [patch 1/5] kexec debug output improvments Vivek Goyal
2007-05-08 7:24 ` Simon Horman
2007-05-08 14:36 ` Geoff Levand
2007-05-08 16:02 ` Vivek Goyal
2007-05-09 1:11 ` Geoff Levand
2007-05-09 4:19 ` Vivek Goyal
2007-05-08 0:02 ` [patch 2/5] kexec improve build for ppc64 Geoff Levand
2007-05-08 6:07 ` Simon Horman
2007-05-08 0:02 ` [patch 3/5] kexec add strict-prototypes Geoff Levand
2007-05-08 2:38 ` Simon Horman
2007-05-08 14:56 ` Geoff Levand
2007-05-09 0:33 ` [patch 1/2] " Geoff Levand
2007-05-09 6:48 ` Simon Horman
2007-05-09 0:33 ` [patch 2/2] kexec fix prototypes for ppc64 Geoff Levand
2007-05-09 6:48 ` Simon Horman
2007-05-08 0:03 ` [patch 4/5] Add proper node alignment for the powerpc device-tree cmdline Geoff Levand
2007-05-08 6:13 ` Simon Horman
2007-05-08 14:50 ` Milton Miller
2007-05-08 0:03 ` [patch 5/5] kexec fix ppc64 device-tree mem node Geoff Levand
2007-05-08 6:14 ` Simon Horman
2007-05-08 14:57 ` Spam:****, " Milton Miller
2007-05-08 6:35 ` Mohan Kumar M
2007-05-08 8:20 ` David Woodhouse
2007-05-09 2:39 ` [patch v2] " Geoff Levand
2007-05-09 22:35 ` Geoff Levand [this message]
2007-05-14 19:08 ` [patch v3] " Geoff Levand
2007-05-15 4:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46424CA7.8060204@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox