Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chandru <chandru@in.ibm.com>
To: Maxim Uvarov <muvarov@gmail.com>
Cc: horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec memory ranges dynamic allocation
Date: Fri, 17 Oct 2008 21:42:48 +0530	[thread overview]
Message-ID: <48F8B980.7000403@in.ibm.com> (raw)
In-Reply-To: <572af9170810140811v446a6874pd67cb77753a9e32d@mail.gmail.com>

Maxim Uvarov wrote:
> Hello all,
>
> As you all know it is not easy to count exact value of memory ranges 
> from device tree on powerpc.
> It very depends on how dts file was written. What do you think about 
> really dynamic allocation buffers
> for this buffers? Patch is attached.
>
> -- 
> Best regards,
> Maxim Uvarov

Maxim,

The changes seem to be better in allocating memory ranges dynamically.   
From the patch, it looks like there are couple of other places in 
get_devtree_details() to make a  call to realloc_memory_ranges(). Also 
the patch removes the initialization of lmb_size and num_of_lmbs which 
are required for  the recent dynamic-reconf-memory changes to 
kexec-tools.  Else these values could also be read from 
/proc/device-tree wherever necessary .   I applied the patch on a ppc64 
machine and got the following

# ./build/sbin/kexec -p /boot/vmlinux-kdump --append="root=/dev/sda3   
elevator=deadline sysrq=1 reset_devices " --initrd=/boot/initrd-kdump
get memory ranges:2
Could not find a free area of memory of 82b2b8 bytes...
Base address: ffffffff is not page aligned

Without the patch , kexec loads the crashkernel in to memory.  Trying to 
see whats wrong...
 
Chandru

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      parent reply	other threads:[~2008-10-17 16:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 15:11 [PATCH] kexec memory ranges dynamic allocation Maxim Uvarov
2008-10-15  3:18 ` Simon Horman
2008-10-15  6:28   ` Maxim Uvarov
2008-10-15  8:46   ` Maxim Uvarov
2008-10-31  2:29     ` Simon Horman
2008-10-31  6:53       ` Maxim Uvarov
2008-11-01  3:16         ` Simon Horman
2008-11-01  8:43           ` Maxim Uvarov
2008-11-02 23:41             ` Simon Horman
2008-10-17 16:12 ` Chandru [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F8B980.7000403@in.ibm.com \
    --to=chandru@in.ibm.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=muvarov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox