From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1Ky1To-0008Vs-A0 for kexec@lists.infradead.org; Thu, 06 Nov 2008 09:48:44 +0000 Message-ID: <4912BD67.8000704@redhat.com> Date: Thu, 06 Nov 2008 11:48:23 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 08/16] x86: Emergency virtualization disable function References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-9-git-send-email-ehabkost@redhat.com> <20081105175235.GJ5247@blackpad> In-Reply-To: <20081105175235.GJ5247@blackpad> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Eduardo Habkost Cc: Andrew Morton , kvm@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , "Eric W. Biederman" , Ingo Molnar , Andrey Borzenkov , mingo@redhat.com, Vivek Goyal Eduardo Habkost wrote: > We could move the set_virt_disable_func() calls to vmx.c and svm.c (on > hardware_setup/hardware_unsetup). One could argue that it is sort of a > coincidence that we need the code for both vmx and svm. > I don't share this fear of function calls, but perhaps that's due to lack of experience with kdump. If you want to be extra simple and safe, remove kvm from the equation. Make the disabling code part of kdump/emergency_restart and only rely on the convention that cr3.vmxe == vmxon. That has the advantage of working with other virtualization systems as well. -- error compiling committee.c: too many arguments to function _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec