From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1L1cWV-0004df-J0 for kexec@lists.infradead.org; Sun, 16 Nov 2008 07:58:23 +0000 Message-ID: <491FD283.60402@redhat.com> Date: Sun, 16 Nov 2008 09:57:55 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3) References: <1226598231-18311-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1226598231-18311-1-git-send-email-ehabkost@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Eduardo Habkost Cc: Andrew Morton , Zachary Amsden , kvm@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , "Eric W. Biederman" , Ingo Molnar , Andrey Borzenkov , mingo@redhat.com, Vivek Goyal Eduardo Habkost wrote: > Hi, > > This is a new spin of the series to disable vmx on kdump and on > emergency_restart. Now we avoid doing the function pointer stuff by > moving 4 small KVM functions to a header, as inline functions. The code > looks much simpler now, but we have to be more careful because some > additional code will run on kdump and reboot even when KVM is never > loaded. > > I haven't tested the SVM changes on AMD CPUs. The changes are really > simple, but some testing is welcome. > > This series is against tip.git#master, that already contains the > nmi_shootdown_cpus() changes I've submitted previously. > > > Looks good. I am slightly uneasy about moving things away from vmx.h and svm.h; can we keep them there and #include those headers directly? -- error compiling committee.c: too many arguments to function _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec