Re: [PATCH 2/4] x86, memblock: Fix crashkernel allocation

H. Peter Anvin
2010-10-05T22:30:48Z

On 10/04/2010 02:57 PM, Yinghai Lu wrote:
>
> +#define DEFAULT_BZIMAGE_ADDR_MAX 0x37FFFFFF
> static void __init reserve_crashkernel(void)
> {
> unsigned long long total_mem;
> @@ -518,17 +519,28 @@ static void __init reserve_crashkernel(v
> if (crash_base <= 0) {
> const unsigned long long alignment = 16<<20; /* 16M */
>
> - crash_base = memblock_find_in_range(alignment, ULONG_MAX, crash_size,
> - alignment);
> + /*
> + * Assume half crash_size is for bzImage
> + * kexec want bzImage is below DEFAULT_BZIMAGE_ADDR_MAX
> + */
> + crash_base = memblock_find_in_range(alignment,
> + DEFAULT_BZIMAGE_ADDR_MAX + crash_size/2,
> + crash_size, alignment);
> +
> if (crash_base == MEMBLOCK_ERROR) {
> - pr_info("crashkernel reservation failed - No suitable area found.\n");
> - return;
> + crash_base = memblock_find_in_range(alignment,
> + ULONG_MAX, crash_size, alignment);
> +
> + if (crash_base == MEMBLOCK_ERROR) {
> + pr_info("crashkernel reservation failed - No suitable area found.\n");
> + return;
> + }
> }
>

Okay, this *really* doesn't make sense.

It's bad enough that kexec doesn't know what memory is safe for it, but
why the heck the heuristic that "half is for bzImage and the rest can go
beyond the heuristic limit"? Can't we at least simply cap the region to
the default, unless the kexec system has passed in some knowable
alternative? Furthermore, why bother having the "fallback" at all
(certainly without having a message!?) If we don't get the memory area
we need we're likely to randomly fail anyway.

Let me be completely clear -- it's obvious from all of this that kexec
is fundamentally broken by design: if kexec can't communicate the safe
memory to use it's busted seven ways to Sunday and it needs to be fixed.
However, in the meantime I can see capping the memory available to it
as a temporary band-aid, but a fallback to picking random memory is
nuts, especially on the motivation that "a future kexec version might be
able to use it." If so, the "future kexec tools" should SAY SO.

This is beyond crazy -- it's complete and total bonkers.