From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Suzuki Poulose <suzuki@in.ibm.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Josh Boyer <jwboyer@linux.vnet.ibm.com>,
linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] Kexec support for PPC440x
Date: Tue, 31 May 2011 17:15:35 +0200 [thread overview]
Message-ID: <4DE50617.7090509@linutronix.de> (raw)
In-Reply-To: <4DE345B0.8020505@in.ibm.com>
Suzuki Poulose wrote:
> Index: powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
> ===================================================================
> --- /dev/null
> +++ powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
....
> + *
> + */
> + bl nxtins /* Find our address */
> +nxtins: mflr r5 /* Make it accessible */
Please don't mix labels and instructions.
> + tlbsx r23,0,r5 /* Find entry we are in */
using tabs instead of spaces would make it look nice. Please also separate
the arguments of the instruction i.e.
tlbsx r23, 0, r5
> Index: powerpc/arch/powerpc/kernel/misc_32.S
> ===================================================================
> --- powerpc.orig/arch/powerpc/kernel/misc_32.S
> +++ powerpc/arch/powerpc/kernel/misc_32.S
> @@ -736,6 +736,28 @@ relocate_new_kernel:
> mr r5, r31
>
> li r0, 0
> +#elif defined(CONFIG_44x) && !defined(CONFIG_47x)
> +
> + mr r29, r3
> + mr r30, r4
> + mr r31, r5
> +
> +#include "44x_kexec_mapping.S"
The way you setup the 1:1 mapping should be close to what you are doing on
kernel entry. Isn't it possible to include the file here and in the entry
code?
Sebastian
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2011-05-31 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 7:22 [RFC][PATCH] Kexec support for PPC440x Suzuki Poulose
2011-05-31 15:15 ` Sebastian Andrzej Siewior [this message]
2011-06-02 6:34 ` Suzuki Poulose
2011-06-03 11:50 ` Suzuki Poulose
2011-06-03 13:53 ` Sebastian Andrzej Siewior
2011-06-29 5:38 ` Suzuki Poulose
2011-06-02 7:25 ` Benjamin Herrenschmidt
2011-06-02 7:30 ` Suzuki Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE50617.7090509@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=ananth@in.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=suzuki@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox