From: Dave Hansen <dave.hansen@intel.com>
To: Yan Zhao <yan.y.zhao@intel.com>, ebiederm@xmission.com
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev, x86@kernel.org,
rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
bhe@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH v2 1/1] kexec_core: Accept unaccepted kexec segments' destination addresses
Date: Wed, 19 Feb 2025 15:16:14 -0800 [thread overview]
Message-ID: <5007ae91-f4d5-430b-a403-aff9af1d6375@intel.com> (raw)
In-Reply-To: <20241213095449.881-1-yan.y.zhao@intel.com>
On 12/13/24 01:54, Yan Zhao wrote:
> Accept the destination addresses during the kexec load, immediately after
> they pass sanity checks. This ensures the code is located in a common place
> shared by both the kexec_load and kexec_file_load system calls.
So, we've got an end-user-visible bug. Eric raised some good concerns
about the hardware and firmware design, but I think they've all been
addressed. The only other even solution I've seen proposed is to not do
unaccepted memory in the first place. I don't think that's viable or
justified, especially since we've got at least one end user[1] that
seems to think unaccepted memory fits their needs.
This bug can _probably_ be fixed in arch/x86 as well, but having the
solution in general code seems like the right place to me:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Andrew, it seems like a lot of kexec work flows through you. Are you the
right one to pick this up?
1.
https://lore.kernel.org/all/CAMGD6P3r-S-Va-TRvVjZ808on9+-wFJ_VeTpQ+FEN1jBbhmnXw@mail.gmail.com/
next prev parent reply other threads:[~2025-02-19 23:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:49 [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses Yan Zhao
2024-12-13 9:54 ` [PATCH v2 1/1] kexec_core: " Yan Zhao
2025-02-13 15:50 ` Dave Hansen
2025-02-14 13:37 ` Kirill A. Shutemov
2025-02-19 23:16 ` Dave Hansen [this message]
2025-01-13 10:01 ` [PATCH v2 0/1] " Kirill A. Shutemov
2025-01-13 11:12 ` Baoquan He
2025-01-13 14:59 ` Eric W. Biederman
2025-01-14 3:26 ` Baoquan He
2025-01-14 7:04 ` Yan Zhao
2025-01-14 10:08 ` Kirill A. Shutemov
2025-02-13 15:55 ` Dave Hansen
2025-02-14 13:46 ` Kirill A. Shutemov
2025-02-14 16:20 ` Dave Hansen
2025-03-04 8:41 ` Kirill A. Shutemov
2025-03-04 18:49 ` Eric W. Biederman
2025-03-04 19:16 ` Dave Hansen
2025-03-12 20:33 ` Dave Hansen
2025-02-19 23:03 ` Jianxiong Gao
2025-02-20 2:27 ` Ashish Kalra
2025-03-04 23:43 ` Andrew Morton
2025-03-04 23:53 ` Andrew Morton
2025-03-04 23:54 ` Andrew Morton
2025-03-13 12:06 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007ae91-f4d5-430b-a403-aff9af1d6375@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox