Re: [PATCH 0/7] makedumpfile security key filtering with eppic

[Aravinda Prasad <aravinda@linux.vnet.ibm.com>]

Hi Atsushi,

On 2012-10-15 10:16, Atsushi Kumagai wrote:

> Hello Mahesh,
> 
> On Fri, 12 Oct 2012 10:59:17 +0530
> Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:
> 
>> On 08/17/2012 09:46 AM, Atsushi Kumagai wrote:
>>> Hello Aravinda,
>>>
>>> On Thu, 16 Aug 2012 11:55:55 +0530
>>> Aravinda Prasad <aravinda@linux.vnet.ibm.com> wrote:
>>>
>>>> Hello Kumagai-san,
>>>>
>>>> Did you get a chance to review the makedumpfile security key enhancement
>>>> patches?
>>>>
>>>> - Aravinda
>>>
>>> Sorry for not responding.
>>>
>>> I'm afraid that I can't start to review them yet.
>>> I've been working on the cyclic mode feature for a few months,
>>> and I'm now preparing the next release including the feature.
>>>
>>> I'll release the next version soon, I'll review your patches after that.
>>>
>>
>> Hi Atsushi,
>>
>> Did you get chance to review these patches?
> 
> I'm sorry for keeping you waiting.
> I have just started reviewing these patches, I have a comment for them.
> 
> These patches require all users to prepare libeppic, but I think 
> it's not good implementation because everyone has to build libeppic
> from the source code themselves, it isn't desirable for the users who
> don't need to use this feature.
> 
> So, I hope to change them to optional like LZO and snappy compression.
> Is it possible ?


Yes it is possible.

I will update the patch to have eppic as optional like LZO. I will
include this along with other changes based on your review comments.

> 
> 
> Thanks
> Atsushi Kumagai
> 


-- 
Regards,
Aravinda


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec