From: Dave Young <dyoung@redhat.com>
To: Khalid Aziz <khalid@gonehiking.org>
Cc: horms@verge.net.au, kexec@lists.infradead.org, vgoyal@redhat.com
Subject: Re: [PATCH]kdump: pass noefi and acpi_rsdp= to 2nd kernel
Date: Mon, 22 Oct 2012 10:05:46 +0800 [thread overview]
Message-ID: <5084A9FA.1090403@redhat.com> (raw)
In-Reply-To: <1350572394.3894.18.camel@rhapsody>
On 10/18/2012 10:59 PM, Khalid Aziz wrote:
> On Thu, 2012-10-18 at 11:12 +0800, Dave Young wrote:
>> On 09/12/2012 10:35 AM, Dave Young wrote:
>>
>>> On 09/07/2012 04:56 PM, Dave Young wrote:
>>>>
>>>> I did some digging about the efi boot kdump in slackware with kernel
>>>> from latest linus tree. I'm surprise that kdump works even without these
>>>> "noefi" and "acpi_rsdp="
>>>>
>>>> With fedora 17 3.4.3 kernel passing "acpi_rsdp=" is enough for kdump
>>>> kernel booting.
>>>>
>>>> Actually in x86 setup code if bootloader do not pass correct efi_info in
>>>> boot_params efi_enabled will be set to 0 automaticlly.
>>>>
>>>> So as for this patch 'noefi' is not needed.
>>>>
>>>> I will do more testing to see why linus tree works without "acpi_rsdp="
>>>>
>>>
>>> There's probably some efi changes between 3.4.3 - 3.6.0-rc4 cause this
>>> works. I have not got time to bisect it.
>>
>>
>> During recent test, I found I mistakenly used wrong kernel config
>> without CONFIG_EFI in 1st kernel for testing. acpi_rsdp= is still needed.
>>
>> Just resent the v2 patch, please help to review.
>>
>
> Hi Dave,
>
> I suspect EFI based systems with Compatibility Support Module (CSM) are
> still not going to need this, but I can see native EFI systems with no
> CSM needing this. I have reviewed your patch.
Good to know, I have no CSM machine to test. Since Simon has applied the
patch, I think I can improve this issue later If I can find a machine
with CSM.
>
> BTW, I am no longer at HP, so <khalid.aziz@hp.com> is no longer valid.
> <khalid@gonehiking.org> is my permanent personal email address.
Thanks for reminding.
>
> --
> Khalid
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
--
Thanks
Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-10-22 2:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 5:44 [PATCH]kdump: pass noefi and acpi_rsdp= to 2nd kernel Dave Young
2012-09-05 7:45 ` Simon Horman
2012-09-06 2:48 ` Dave Young
2012-09-05 13:18 ` Vivek Goyal
2012-09-06 2:58 ` Dave Young
2012-09-06 20:46 ` Vivek Goyal
2012-09-05 23:09 ` Khalid Aziz
2012-09-06 3:18 ` Dave Young
2012-09-06 17:57 ` Khalid Aziz
2012-09-07 8:56 ` Dave Young
2012-09-07 14:37 ` Khalid Aziz
2012-09-13 13:38 ` Vivek Goyal
2012-09-14 20:32 ` Khalid Aziz
2012-09-20 7:49 ` Eric W. Biederman
2012-09-21 22:50 ` Khalid Aziz
2012-09-12 2:35 ` Dave Young
2012-10-18 3:12 ` Dave Young
2012-10-18 14:59 ` Khalid Aziz
2012-10-22 2:05 ` Dave Young [this message]
2012-09-06 20:24 ` Vivek Goyal
2012-09-07 14:32 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5084A9FA.1090403@redhat.com \
--to=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=khalid@gonehiking.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).