public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Haren Myneni <hbabu@us.ibm.com>,
	Simon Horman <horms@verge.net.au>,
	Yinghai Lu <yinghai@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	kexec@lists.infradead.org
Subject: Re: [PATCH v3 4/4] kexec, x86_64: Load bzImage64 above 4G
Date: Wed, 21 Nov 2012 09:24:40 -0800	[thread overview]
Message-ID: <50AD0E58.4010000@zytor.com> (raw)
In-Reply-To: <20121121143729.GC13114@redhat.com>

On 11/21/2012 06:37 AM, Vivek Goyal wrote:
> On Tue, Nov 20, 2012 at 11:31:38PM -0800, Yinghai Lu wrote:
>
> [..]
>> +	/* avoid cross GB boundary */
>> +	align = real_mode->kernel_alignment;
>> +	addr = locate_hole(info, size, align, 0x100000, -1, -1);
>> +	if (addr == ULONG_MAX)
>> +		die("can not load bzImage64");
>> +	/* same GB ? */
>> +	while ((addr >> 30) != ((addr + size - 1) >> 30)) {
>> +		addr = locate_hole(info, size, align, 0x100000,
>> +				 round_down(addr + size - 1, (1UL<<30)), -1);
>> +		if (addr == ULONG_MAX)
>> +			die("can not load bzImage64");
>> +	}
>> +	dbgprintf("Found kernel buffer at %lx size %lx\n", addr, size);
>
> Where does this limitation of not loading kernel across GB boundary come
> from?
>

Seriously... that is bizarre.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-11-21 17:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  7:31 [PATCH v3 0/4] kexec: put bzImage and ramdisk above 4G for x86 64bit Yinghai Lu
2012-11-21  7:31 ` [PATCH v3 1/4] kexec, x86: add boot header member for version 2.12 Yinghai Lu
2012-11-21  7:31 ` [PATCH v3 2/4] kexec, x86: put ramdisk high for 64bit bzImage Yinghai Lu
2012-11-21  7:31 ` [PATCH v3 3/4] kexec, x86: set ext_cmd_line_ptr when boot_param is above 4g Yinghai Lu
2012-11-21  7:31 ` [PATCH v3 4/4] kexec, x86_64: Load bzImage64 above 4G Yinghai Lu
2012-11-21 14:37   ` Vivek Goyal
2012-11-21 17:24     ` H. Peter Anvin [this message]
2012-11-21 19:54     ` Yinghai Lu
2012-11-21 19:56       ` H. Peter Anvin
2012-11-21 20:01         ` Yinghai Lu
2012-11-21 20:16           ` H. Peter Anvin
2012-11-21 20:47             ` Yinghai Lu
2012-11-21 20:56               ` H. Peter Anvin
2012-11-21 23:34               ` H. Peter Anvin
2012-11-22  5:52                 ` Yinghai Lu
2012-11-21 14:50   ` Vivek Goyal
2012-11-21 19:50     ` Yinghai Lu
2012-11-21 19:52       ` H. Peter Anvin
2012-11-21 19:57         ` Yinghai Lu
2012-11-21 20:00       ` Vivek Goyal
2012-11-21 20:09         ` Yinghai Lu
2012-11-21 20:12           ` Vivek Goyal
2012-11-21 20:17             ` Yinghai Lu
2012-11-21 20:07       ` Vivek Goyal
2012-11-22 11:39         ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AD0E58.4010000@zytor.com \
    --to=hpa@zytor.com \
    --cc=ebiederm@xmission.com \
    --cc=hbabu@us.ibm.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox