From: David Daney <ddaney.cavm@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, ralf@linux-mips.org,
David Daney <ddaney.cavm@gmail.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] kexec: Fix compile errors in crashdump-mips.c
Date: Thu, 29 Nov 2012 16:12:38 -0800 [thread overview]
Message-ID: <50B7F9F6.1030806@gmail.com> (raw)
In-Reply-To: <20121130000243.GC21935@verge.net.au>
On 11/29/2012 04:02 PM, Simon Horman wrote:
> On Thu, Nov 29, 2012 at 12:02:49PM -0800, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> When building configured as '--host=mips64-octeon-linux-gnu' using
>> GCC-4.7.0 there are two compile errors, fix them.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>
> Thanks, is the first hunk also ok on 32bit?
Yes, in crashdump.h kern_size is declared as type unsigned long, so the
proper printf format is ABI independent and should be "%lx"
>
>> ---
>> kexec/arch/mips/crashdump-mips.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kexec/arch/mips/crashdump-mips.c b/kexec/arch/mips/crashdump-mips.c
>> index f988698..6f9f6c6 100644
>> --- a/kexec/arch/mips/crashdump-mips.c
>> +++ b/kexec/arch/mips/crashdump-mips.c
>> @@ -83,7 +83,7 @@ static int get_kernel_vaddr_and_size(struct crash_elf_info *elf_info,
>> dbgprintf("kernel_vaddr= 0x%llx paddr %llx\n",
>> elf_info->kern_vaddr_start,
>> elf_info->kern_paddr_start);
>> - dbgprintf("kernel size = 0x%llx\n", elf_info->kern_size);
>> + dbgprintf("kernel size = 0x%lx\n", elf_info->kern_size);
>> return 0;
>> }
>> fprintf(stderr, "Cannot determine kernel virtual load addr and size\n");
>> @@ -356,7 +356,7 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
>> #ifdef __mips64
>> if (arch_options.core_header_type == CORE_TYPE_ELF64) {
>> elf_info = &elf_info64;
>> - crash_create = crash_create_elf64;
>> + crash_create = crash_create_elf64_headers;
>> start_offset = 0xffffffff80000000UL;
>> }
>> #endif
>> --
>> 1.7.11.7
>>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-11-30 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 20:02 [PATCH] kexec: Fix compile errors in crashdump-mips.c David Daney
2012-11-30 0:02 ` Simon Horman
2012-11-30 0:12 ` David Daney [this message]
2012-12-03 7:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B7F9F6.1030806@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=david.daney@cavium.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox