From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TgqiC-0001Ia-Rd for kexec@lists.infradead.org; Fri, 07 Dec 2012 05:43:02 +0000 Message-ID: <50C18168.305@cn.fujitsu.com> Date: Fri, 07 Dec 2012 13:40:56 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: [PATCH] x86/kexec: crash_vmclear_local_vmcss needs __rcu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Eric W. Biederman" , Gleb Natapov Cc: kbuild test robot , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" This removes the sparse warning: arch/x86/kernel/crash.c:49:32: sparse: incompatible types in comparison expression (different address spaces) Reported-by: kbuild test robot Signed-off-by: Zhang Yanfei --- arch/x86/include/asm/kexec.h | 4 +++- arch/x86/kernel/crash.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h index 28feeba..16882cd 100644 --- a/arch/x86/include/asm/kexec.h +++ b/arch/x86/include/asm/kexec.h @@ -163,7 +163,9 @@ struct kimage_arch { }; #endif -extern void (*crash_vmclear_loaded_vmcss)(void); +extern void __rcu (*crash_vmclear_loaded_vmcss)(void); +#define vmclear_func_rcu(vmclear_func) \ + ((void (*)(void)) rcu_dereference(vmclear_func)) #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 2f6b8e8..50ce1d6 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -38,7 +38,7 @@ int in_crash_kexec; * * protected by rcu. */ -void (*crash_vmclear_loaded_vmcss)(void) = NULL; +void __rcu (*crash_vmclear_loaded_vmcss)(void) = NULL; EXPORT_SYMBOL_GPL(crash_vmclear_loaded_vmcss); static inline void cpu_crash_vmclear_loaded_vmcss(void) @@ -46,7 +46,7 @@ static inline void cpu_crash_vmclear_loaded_vmcss(void) void (*do_vmclear_operation)(void) = NULL; rcu_read_lock(); - do_vmclear_operation = rcu_dereference(crash_vmclear_loaded_vmcss); + do_vmclear_operation = vmclear_func_rcu(crash_vmclear_loaded_vmcss); if (do_vmclear_operation) do_vmclear_operation(); rcu_read_unlock(); -- 1.7.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec