Re: [PATCH v2 0/7] makedumpfile security key filtering with eppic

Vivek Goyal
2012-11-21T13:57:33Z

On Wed, Nov 21, 2012 at 12:49:58PM +0530, Aravinda Prasad wrote:
>
>
> On 2012-11-20 15:17, Atsushi Kumagai wrote:
>
> ...
>
>
> >>>
> >>>
> >>> As I mentioned, we don't need vmlinux in initramfs as filtering is done
> >>> during post processing only.
> >>
> >> You are missing the point. The point is that despite the fact that
> >> scrubbing will never be done from initramfs, all the users will pay
> >> penalty for increased makedumpfile size.
> >>
> >> So why not write a separate tool (scrub-vmcore) so that makedumpfile
> >> users don't pay the bloated size penatly.
> >
> > As Vivek said, I think it's difficult to persuade almost all distributor
> > to specify EPPIC=on.
> >
> > So, it seems that separate tool is better way for both user and distributor.
> > If you will make it, I will drop eppic support from v1.5.1 and export core
> > functions from makedumpfile as library for such tools in the future.
> >
> > Does this meet your purpose, Aravinda ?
>
>
> Vivek, Atsushi,
>
> How about distributions building two targets one with default
> makedumpfile and other with EPPIC=on, which can be done by a simple
> modification to Makefile.

That's not a good idea. Generally distributions don't ship multiple
binaries with minor differences like that. I think going with a
separate tool for doing this kind of filtering is better.

Thanks
Vivek