From: Mitsuhiro Tanino <mitsuhiro.tanino.gm@hitachi.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>,
ebiederm@xmission.com
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
vgoyal@redhat.com
Subject: Re: [PATCH 2/2 v2] kexec: Export PG_hwpoison flag into vmcoreinfo
Date: Tue, 12 Feb 2013 12:07:13 +0900 [thread overview]
Message-ID: <5119B1E1.4010405@hitachi.com> (raw)
In-Reply-To: <20130208174944.96a3b50952e45e1219a94819@mxc.nes.nec.co.jp>
Re: [Patch 0/2] Exclude hwpoison page from vmcore dump
(2012/11/01 19:40), Eric W. Biederman wrote:
> Mitsuhiro Tanino <mitsuhiro.tanino.gm@hitachi.com> writes:
> I agree. If we are performing filtering filtering out of poisoned pages
> seems very reasonable. So ack on the basic concept.
>
> Eric
Hello, Eric,
Could you please push the patch to export PG_hwpoison flag into 3.9 during
next merge window?
Kumagai-san acked the patch which provides the feature to exclude hwpoison
page and he will push the fix of makedumpfile side into makedumpfile-1.5.2.
This kernel patch is also required to enable this feature.
Regards,
Mitsuhiro Tanino
(2013/02/08 17:49), Atsushi Kumagai wrote:
> Hello,
>
> On Wed, 31 Oct 2012 23:05:05 +0900
> Mitsuhiro Tanino <mitsuhiro.tanino.gm@hitachi.com> wrote:
>
>> This patch exports a PG_hwpoison into vmcoreinfo when
>> CONFIG_MEMORY_FAILURE is defined.
>> "makedumpfile" needs to read information of memory, such as
>> 'mem_section', 'zone', 'pageflags' from vmcore.
>>
>> We introduce a function into "makedumpfile" to exclude
>> hwpoison page from vmcore dump.
>> In order to introduce this function, PG_hwpoison flag have
>> to export into vmcoreinfo.
>>
>> Signed-off-by: Mitsuhiro Tanino <mitsuhiro.tanino.gm@hitachi.com>
>
> I'm curious to know the status of this patch because I'll release
> makedumpfile-1.5.2 with the feature to exclude hwpoison page soon.
>
>
> Thanks
> Atsushi Kumagai
>
>> ---
>> kernel/kexec.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/kernel/kexec.c b/kernel/kexec.c
>> index 0668d58..0d5d6bc 100644
>> --- a/kernel/kexec.c
>> +++ b/kernel/kexec.c
>> @@ -1513,6 +1513,9 @@ static int __init crash_save_vmcoreinfo_init(void)
>> VMCOREINFO_NUMBER(PG_lru);
>> VMCOREINFO_NUMBER(PG_private);
>> VMCOREINFO_NUMBER(PG_swapcache);
>> +#ifdef CONFIG_MEMORY_FAILURE
>> + VMCOREINFO_NUMBER(PG_hwpoison);
>> +#endif
>>
>> arch_crash_save_vmcoreinfo();
>> update_vmcoreinfo_note();
>> --
>> 1.7.10.1
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> .
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-02-12 3:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:06 [Patch 0/2] Exclude hwpoison page from vmcore dump Mitsuhiro Tanino
2012-10-30 14:37 ` Vivek Goyal
2012-10-31 13:51 ` Mitsuhiro Tanino
2012-10-31 14:14 ` Vivek Goyal
2012-11-01 10:32 ` Mitsuhiro Tanino
2012-11-01 10:40 ` Eric W. Biederman
2012-10-31 14:04 ` [PATCH 0/2 v2] " Mitsuhiro Tanino
2012-10-31 14:05 ` [PATCH 1/2 v2] makedumpfile: Add a default action to exclude hwpoison page from vmcore Mitsuhiro Tanino
2012-11-05 6:04 ` Atsushi Kumagai
2012-10-31 14:05 ` [PATCH 2/2 v2] kexec: Export PG_hwpoison flag into vmcoreinfo Mitsuhiro Tanino
2013-02-08 8:49 ` Atsushi Kumagai
2013-02-12 3:07 ` Mitsuhiro Tanino [this message]
2013-02-12 10:58 ` Eric W. Biederman
2013-02-12 13:29 ` Mitsuhiro Tanino
2013-02-15 8:48 ` Mitsuhiro Tanino
2013-02-15 9:35 ` Atsushi Kumagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5119B1E1.4010405@hitachi.com \
--to=mitsuhiro.tanino.gm@hitachi.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox