From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from [222.73.24.84] (helo=song.cn.fujitsu.com)
 by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux))
 id 1U8isy-0005mw-80
 for kexec@lists.infradead.org; Fri, 22 Feb 2013 03:01:21 +0000
Message-ID: <5126DC06.5020005@cn.fujitsu.com>
Date: Fri, 22 Feb 2013 10:46:30 +0800
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [PATCH] kexec: prevent double free on image allocation failure
References: <1361496375-30994-1-git-send-email-sasha.levin@oracle.com>
 <87vc9l5cz4.fsf@xmission.com>
In-Reply-To: <87vc9l5cz4.fsf@xmission.com>
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
Sender: kexec-bounces@lists.infradead.org
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Sasha Levin <sasha.levin@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org

09ogMjAxM8TqMDLUwjIyyNUgMDk6NTUsIEVyaWMgVy4gQmllZGVybWFuINC0tcA6Cj4gU2FzaGEg
TGV2aW4gPHNhc2hhLmxldmluQG9yYWNsZS5jb20+IHdyaXRlczoKPiAKPj4gSWYga2ltYWdlX25v
cm1hbF9hbGxvYygpIGZhaWxzIHRvIGluaXRpYWxpemUgYW4gYWxsb2NhdGVkIGtpbWFnZSwgaXQg
d2lsbCBmcmVlCj4+IHRoZSBpbWFnZSBidXQgd291bGQgc3RpbGwgc2V0ICdyaW1hZ2UnLCBhcyBh
IHJlc3VsdCBrZXhlY19sb2FkIHdpbGwgdHJ5Cj4+IHRvIGZyZWUgaXQgYWdhaW4uCj4+Cj4+IFRo
aXMgd291bGQgZXhwbG9kZSBhcyBwYXJ0IG9mIHRoZSBmcmVlaW5nIHByb2Nlc3MgaXMgYWNjZXNz
aW5nIGludGVybmFsCj4+IG1lbWJlcnMgd2hpY2ggcG9pbnQgdG8gdW5pbml0aWFsaXplZCBtZW1v
cnkuCj4gCj4gQWdyZWVkLgo+IAo+IEkgZG9uJ3QgdGhpbmsgdGhhdCBmYWlsdXJlIHBhdGggaGFz
IGV2ZXIgYWN0dWFsbHkgYmVlbiBleGVyY2lzZWQuCj4gCj4gVGhlIGNvZGUgaXMgd3JvbmcsIGFu
ZCBpdCBpcyB3b3J0aCBmaXhpbmcuCj4gCj4gQW5kcmV3IEkgZG8geW91IHRoaW5rIHlvdSBjb3Vs
ZCBxdWV1ZSB0aGlzIHVwPyAgSSBkb24ndCBoYXZlIGEgaGFuZHkgdHJlZS4KCgpJIHN0aWxsIGZv
dW5kIGFub3RoZXIgbWFsbG9jL2ZyZWUgcHJvYmxlbSBpbiB0aGlzIGZ1bmN0aW9uLiBTbyBJIHVw
ZGF0ZSB0aGUgcGF0Y2guCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0KCkZyb20gMWZiNzZhMzVlNDEw
OWUxNDM1ZjU1MDQ4YzIwZWE1ODYyMmU3Zjg3YiBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKRnJv
bTogWmhhbmcgWWFuZmVpIDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KRGF0ZTogRnJpLCAy
MiBGZWIgMjAxMyAxMDozNDowMiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGtleGVjOiBmaXggYWxs
b2NhdGlvbiBwcm9ibGVtcyBpbiBmdW5jdGlvbiBraW1hZ2Vfbm9ybWFsX2FsbG9jCgpUaGUgZnVu
Y3Rpb24ga2ltYWdlX25vcm1hbF9hbGxvYygpIGhhcyAyIGFsbG9jYXRpb24gcHJvYmxlbXMgdGhh
dCBtYXkgY2F1c2UKZmFpbHVyZXM6CgogIDEuIElmIGtpbWFnZV9ub3JtYWxfYWxsb2MoKSBmYWls
cyB0byBpbml0aWFsaXplIGFuIGFsbG9jYXRlZCBraW1hZ2UsIGl0IHdpbGwKICAgICBmcmVlIHRo
ZSBpbWFnZSBidXQgd291bGQgc3RpbGwgc2V0ICdyaW1hZ2UnLCBhcyBhIHJlc3VsdCBrZXhlY19s
b2FkIHdpbGwKICAgICB0cnkgdG8gZnJlZSBpdCBhZ2Fpbi4KCiAgICAgVGhpcyB3b3VsZCBleHBs
b2RlIGFzIHBhcnQgb2YgdGhlIGZyZWVpbmcgcHJvY2VzcyBpcyBhY2Nlc3NpbmcgaW50ZXJuYWwK
ICAgICBtZW1iZXJzIHdoaWNoIHBvaW50IHRvIHVuaW5pdGlhbGl6ZWQgbWVtb3J5LgoKICAyLiBJ
ZiBraW1hZ2Vfbm9ybWFsX2FsbG9jKCkgZmFpbHMgdG8gYWxsb2MgcGFnZXMgZm9yIGltYWdlLT5z
d2FwX3BhZ2UsIGl0CiAgICAgc2hvdWxkIGNhbGwga2ltYWdlX2ZyZWVfcGFnZV9saXN0KCkgdG8g
ZnJlZSBhbGxvY2F0ZWQgcGFnZXMgaW4KICAgICBpbWFnZS0+Y29udHJvbF9wYWdlcyBsaXN0IGJl
Zm9yZSBpdCBmcmVlcyBpbWFnZS4KClNpZ25lZC1vZmYtYnk6IFNhc2hhIExldmluIDxzYXNoYS5s
ZXZpbkBvcmFjbGUuY29tPgpTaWduZWQtb2ZmLWJ5OiBaaGFuZyBZYW5mZWkgPHpoYW5neWFuZmVp
QGNuLmZ1aml0c3UuY29tPgotLS0KIGtlcm5lbC9rZXhlYy5jIHwgICAxMCArKysrKystLS0tCiAx
IGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9rZXJuZWwva2V4ZWMuYyBiL2tlcm5lbC9rZXhlYy5jCmluZGV4IDVlNGJkNzguLmYyMTkz
NTcgMTAwNjQ0Ci0tLSBhL2tlcm5lbC9rZXhlYy5jCisrKyBiL2tlcm5lbC9rZXhlYy5jCkBAIC0y
MjMsNiArMjIzLDggQEAgb3V0OgogCiB9CiAKK3N0YXRpYyB2b2lkIGtpbWFnZV9mcmVlX3BhZ2Vf
bGlzdChzdHJ1Y3QgbGlzdF9oZWFkICpsaXN0KTsKKwogc3RhdGljIGludCBraW1hZ2Vfbm9ybWFs
X2FsbG9jKHN0cnVjdCBraW1hZ2UgKipyaW1hZ2UsIHVuc2lnbmVkIGxvbmcgZW50cnksCiAJCQkJ
dW5zaWduZWQgbG9uZyBucl9zZWdtZW50cywKIAkJCQlzdHJ1Y3Qga2V4ZWNfc2VnbWVudCBfX3Vz
ZXIgKnNlZ21lbnRzKQpAQCAtMjM2LDggKzIzOCw2IEBAIHN0YXRpYyBpbnQga2ltYWdlX25vcm1h
bF9hbGxvYyhzdHJ1Y3Qga2ltYWdlICoqcmltYWdlLCB1bnNpZ25lZCBsb25nIGVudHJ5LAogCWlm
IChyZXN1bHQpCiAJCWdvdG8gb3V0OwogCi0JKnJpbWFnZSA9IGltYWdlOwotCiAJLyoKIAkgKiBG
aW5kIGEgbG9jYXRpb24gZm9yIHRoZSBjb250cm9sIGNvZGUgYnVmZmVyLCBhbmQgYWRkIGl0CiAJ
ICogdGhlIHZlY3RvciBvZiBzZWdtZW50cyBzbyB0aGF0IGl0J3MgcGFnZXMgd2lsbCBhbHNvIGJl
CkBAIC0yNTksMTAgKzI1OSwxMiBAQCBzdGF0aWMgaW50IGtpbWFnZV9ub3JtYWxfYWxsb2Moc3Ry
dWN0IGtpbWFnZSAqKnJpbWFnZSwgdW5zaWduZWQgbG9uZyBlbnRyeSwKIAogCXJlc3VsdCA9IDA7
CiAgb3V0OgotCWlmIChyZXN1bHQgPT0gMCkKKwlpZiAocmVzdWx0ID09IDApIHsKIAkJKnJpbWFn
ZSA9IGltYWdlOwotCWVsc2UKKwl9IGVsc2UgeworCQlraW1hZ2VfZnJlZV9wYWdlX2xpc3QoJmlt
YWdlLT5jb250cm9sX3BhZ2VzKTsKIAkJa2ZyZWUoaW1hZ2UpOworCX0KIAogCXJldHVybiByZXN1
bHQ7CiB9Ci0tIAoxLjcuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0
dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK