From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.citrix.com ([66.165.176.89]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDvfN-0004Ms-QZ for kexec@lists.infradead.org; Fri, 08 Mar 2013 11:40:51 +0000 Message-ID: <5139CE3C.8070801@citrix.com> Date: Fri, 8 Mar 2013 11:40:44 +0000 From: David Vrabel MIME-Version: 1.0 Subject: Re: [PATCH 5/8] kexec: extend hypercall with improved load/unload ops References: <1361468894-18655-1-git-send-email-david.vrabel@citrix.com> <1361468894-18655-6-git-send-email-david.vrabel@citrix.com> <20130308112301.GE10740@debian70-amd64.local.net-space.pl> In-Reply-To: <20130308112301.GE10740@debian70-amd64.local.net-space.pl> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Daniel Kiper Cc: "kexec@lists.infradead.org" , "xen-devel@lists.xen.org" On 08/03/13 11:23, Daniel Kiper wrote: > On Thu, Feb 21, 2013 at 05:48:11PM +0000, David Vrabel wrote: >> >> + /* Need to switch to 32-bit mode? */ >> + testq $KEXEC_RELOC_FLAG_COMPAT, %r8 >> + jnz call_32_bit > > Why do you need that? This is not needed because purgatory code > from kexec-tools always switches to 32-bit mode. Please check > kexec-tools/purgatory/arch/x86_64/entry64.S. The sub-architecture is a property of the image. Why should the tool know or care about the sub-architecture of the hypervisor? The ABI isn't designed only for kexec-tools. David _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec