public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec <kexec@lists.infradead.org>, CAI Qian <caiqian@redhat.com>,
	Cliff Wickman <cpw@sgi.com>
Subject: Re: failed to compile kexec from git
Date: Wed, 13 Mar 2013 17:57:58 +0800	[thread overview]
Message-ID: <51404DA6.5010106@cn.fujitsu.com> (raw)
In-Reply-To: <20130313095210.GF26746@verge.net.au>

于 2013年03月13日 17:52, Simon Horman 写道:
> On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote:
>> If I revert this commit,
>> 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
>> kexec x86: drop truncation warning for crash kernel
>>
>> Everything is fine again.
> 
> Thanks. I have applied the following patch which I believe resolves
> the problem. Cliff, could you test this?

oops...I've sent the same patch before and WANG chao <chaowang@redhat.com>
tested it and it is ok now.

Thanks
Zhang

> 
> commit 51438a32f6a0f09a358742f06196d14e4ad0ccab
> Author: Simon Horman <horms@verge.net.au>
> Date:   Wed Mar 13 10:48:48 2013 +0100
> 
>     Correct build failure in init_linux_parameters()
>     
>     This fixes a build failure introduced by
>     "kexec x86: drop truncation warning for crash kernel".
>     
>     Reported-by: CAI Qian <caiqian@redhat.com>
>     Cc: Cliff Wickman <cpw@sgi.com>
>     Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
> index b903d43..454fad6 100644
> --- a/kexec/arch/i386/x86-linux-setup.c
> +++ b/kexec/arch/i386/x86-linux-setup.c
> @@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
>  	range = info->memory_range;
>  	ranges = info->memory_ranges;
>  	if (ranges > E820MAX) {
> -		if (!(kexec_flags & KEXEC_ON_CRASH))
> +		if (!(info->kexec_flags & KEXEC_ON_CRASH))
>  			/*
>  			 * this e820 not used for capture kernel, see
>  			 * do_bzImage_load()
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-03-13 10:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13  2:52 failed to compile kexec from git CAI Qian
2013-03-13  3:08 ` CAI Qian
2013-03-13  9:52   ` Simon Horman
2013-03-13  9:57     ` Zhang Yanfei [this message]
2013-03-13 15:16       ` Simon Horman
2013-03-13  3:19 ` Zhang Yanfei
2013-03-13  4:23   ` WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51404DA6.5010106@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=caiqian@redhat.com \
    --cc=cpw@sgi.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox