Re: [PATCH 2/2] kexec: Use err() instead of fprintf()

Simon Horman
2013-03-27T12:43:20Z

On Mon, Mar 25, 2013 at 11:21:51PM +0800, Zhang Yanfei wrote:
> 于 2013年03月20日 21:21, Simon Horman 写道:
> > On Wed, Mar 20, 2013 at 09:17:51PM +0800, Zhang Yanfei wrote:
> >> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >>
> >> Since we have the err() interface, so replace the error printing
> >> function with err().
> >
> > This patch introduces a lot of code changes and I'm not entirely
> > sure that I see the benefit.
>
> Sorry for the long patch.
>
> I just wanted to use a simpler error displaying function instead of
> fprintf(stderr, ...). Just like we use die() or dbgprintf. If you
> think this is unnecessary, just ignore the patch please.

I think that I would prefer to not accept this patch at this time.
Thanks all the same.