public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, Cliff Wickman <cpw@sgi.com>
Subject: Re: [PATCH] kexec: lengthen the kernel command line image
Date: Mon, 25 Mar 2013 15:42:09 +0800	[thread overview]
Message-ID: <514FFFD1.5080704@cn.fujitsu.com> (raw)
In-Reply-To: <20130305015127.GA28547@verge.net.au>

于 2013年03月05日 09:51, Simon Horman 写道:
> On Mon, Feb 04, 2013 at 01:53:55PM -0600, Cliff Wickman wrote:
>> From: Cliff Wickman <cpw@sgi.com>
>>
>> The crash kernel's boot command line is not long enough to contain the
>> necessary memmap= options for a large memory.
>>
>> The fix is simple, as long as the boot loader's command line is also long enough.
>> I'm not sure about boot loader or kernel restrictions to this length.
>>
>> Signed-off-by: Cliff Wickman <cpw@sgi.com>
> 
> Thanks, applied.

Hello

I have a question about this patch.

In x86 code, COMMAND_LINE_SIZE is defined as below:

arch/x86/include/asm/setup.h

#define COMMAND_LINE_SIZE 2048

So even the patch lengthens the commandline length here, when reboot into
the new kernel, the commandline will still be stripped to 2048? right?

So the patch seems unnecessary or unusable. Correct me if I am wrong.

Thanks
Zhang

> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-03-25  7:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 19:53 [PATCH] kexec: lengthen the kernel command line image Cliff Wickman
2013-03-05  1:51 ` Simon Horman
2013-03-25  7:42   ` Zhang Yanfei [this message]
2013-03-25 12:39     ` Cliff Wickman
2013-03-25 15:01       ` Zhang Yanfei
2013-03-27 12:24         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514FFFD1.5080704@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=cpw@sgi.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox