public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: Re: [PATCH] purgatory: compile sha256.c only on ia64 with -O0
Date: Mon, 01 Apr 2013 12:05:55 +0200	[thread overview]
Message-ID: <51595C03.6030302@nod.at> (raw)
In-Reply-To: <51591849.2000502@cn.fujitsu.com>

Simon, Zhang,

Am 01.04.2013 07:16, schrieb Zhang Yanfei:
>> I believe the above portion will break make dist my
>> causing it to omit purgatory/arch/* other than
>> purgatory/arch/$(ARCH)
>
> Ah, I've missed this in my review, too.
>
> Other than this, the change about purgatory/sha256.o below looks sound,
> right?

The dist mechanism is quite strange and error prone.
Why can't you just use git archive in the $(TARBALL) target?
I'll happily send a patch...

Back to the purgatory/sha256.o issue, I did some more tests.
First I thought memcpy() within purgatory is slow, but it isn't.
Does kexec reset the CPU so some kind of legacy mode during purgatory?
It looks like the same code in sha256.o is fast in normal user space
but very slow during purgatory.

Computing sha256 of a 9MiB blob takes less than a second in user space
and 16 seconds (with my patch). Otherwise it takes > 25 seconds.

Thanks,
//richard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2013-04-01 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-31 20:59 [PATCH] purgatory: compile sha256.c only on ia64 with -O0 Richard Weinberger
2013-04-01  1:59 ` Zhang Yanfei
2013-04-01  5:04 ` Simon Horman
2013-04-01  5:16   ` Zhang Yanfei
2013-04-01 10:05     ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51595C03.6030302@nod.at \
    --to=richard@nod.at \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox