From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Richard Weinberger <richard@nod.at>
Cc: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: Re: [PATCH 2/2] [RFC] get rid of dist
Date: Tue, 02 Apr 2013 13:51:41 +0800 [thread overview]
Message-ID: <515A71ED.7050104@cn.fujitsu.com> (raw)
In-Reply-To: <515A6E6E.8030805@nod.at>
于 2013年04月02日 13:36, Richard Weinberger 写道:
> Simon,
>
> Am 02.04.2013 03:10, schrieb Simon Horman:
>> On Mon, Apr 01, 2013 at 01:23:05PM +0200, Richard Weinberger wrote:
>>> Replace the dist variable by git ls-files.
>>> The following files are now included in the dist tarball too:
>>
>> I'm sorry but I don't think it is reasonable to
>> add git as a requirement for building a tarball.
>
> It is not about building a tarball, it is about tracking files.
> Currently you are abusing make to keep track of your files.
> git does this already for you.
> Tracking files manually in the Makefile is also error prone.
> doc/mpc85xx.txt and arch/i386/timer.c have already been forgotten...
> If I'm not mistaken kexec-tools uses git as SCM, so you'll need
> git anyways to checkout the source and work with it.
>
I think what simon meant is that by using current ways, we can build a
tarball without git installed. By using your ways, if we want to build
a tarball, git is a must. So it is unnecessary to add git as a requirement
for there may be some condtions that we want to build a clean tarball in a
git-not-installed system.
Thanks
Zhang
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-04-02 5:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 11:23 [PATCH 1/2] purgatory: remove arch/i386/timer.c Richard Weinberger
2013-04-01 11:23 ` [PATCH 2/2] [RFC] get rid of dist Richard Weinberger
2013-04-01 11:26 ` Richard Weinberger
2013-04-02 1:10 ` Simon Horman
2013-04-02 5:36 ` Richard Weinberger
2013-04-02 5:51 ` Zhang Yanfei [this message]
2013-04-02 5:55 ` Richard Weinberger
2013-04-02 6:09 ` Zhang Yanfei
2013-04-02 5:20 ` Richard Weinberger
2013-04-02 9:03 ` Simon Horman
2013-04-02 9:27 ` Richard Weinberger
2013-04-01 11:28 ` [PATCH 2/2 v2] " Richard Weinberger
2013-04-02 1:09 ` [PATCH 1/2] purgatory: remove arch/i386/timer.c Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A71ED.7050104@cn.fujitsu.com \
--to=zhangyanfei@cn.fujitsu.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox