From: David Vrabel <david.vrabel@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 5/8] kexec: extend hypercall with improved load/unload ops
Date: Mon, 15 Apr 2013 19:58:30 +0100 [thread overview]
Message-ID: <516C4DD6.4020805@citrix.com> (raw)
In-Reply-To: <20130409210241.GB31533@debian70-amd64.local.net-space.pl>
On 09/04/13 22:02, Daniel Kiper wrote:
> On Mon, Apr 08, 2013 at 07:59:50PM +0100, David Vrabel wrote:
>>
>> +
>> + /* Jump to identity mapped code. */
>> + movq %rdi, %r9
>> + addq $(identity_mapped - kexec_reloc), %r9
>> +
>> + jmp *%r9
>
> jmpq *(identity_mapped - kexec_reloc)(%rdi)
This isn't equivalent. It loads the value at the specified memory
location and jumps to that address.
leaq (identity_mapped - kexec_reloc)(%rdi), %rax
jmpq *%rax
Does the right thing.
David
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-04-15 18:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:59 [PATCHv3 0/8] kexec: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-04-08 18:59 ` [PATCH 1/8] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-04-09 7:27 ` [Xen-devel] " Jan Beulich
2013-04-09 16:15 ` David Vrabel
2013-04-08 18:59 ` [PATCH 2/8] xen: make GUEST_HANDLE_64() and uint64_aligned_t available everywhere David Vrabel
2013-04-08 18:59 ` [PATCH 3/8] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-04-09 7:32 ` [Xen-devel] " Jan Beulich
2013-04-12 11:56 ` David Vrabel
2013-04-12 13:01 ` Jan Beulich
2013-04-08 18:59 ` [PATCH 4/8] kexec: add infrastructure for handling kexec images David Vrabel
2013-04-09 7:44 ` [Xen-devel] " Jan Beulich
2013-04-09 16:17 ` David Vrabel
2013-04-10 8:36 ` Jan Beulich
2013-04-08 18:59 ` [PATCH 5/8] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-04-09 21:02 ` Daniel Kiper
2013-04-15 18:58 ` David Vrabel [this message]
2013-04-16 12:05 ` Daniel Kiper
2013-04-16 14:57 ` David Vrabel
2013-04-08 18:59 ` [PATCH 6/8] xen: kexec crash image when dom0 crashes David Vrabel
2013-04-09 21:11 ` Daniel Kiper
2013-04-08 18:59 ` [PATCH 7/8] libxc: add hypercall buffer arrays David Vrabel
2013-04-08 18:59 ` [PATCH 8/8] libxc: add API for kexec hypercall David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2013-04-16 17:13 [PATCHv4 0/8] kexec: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-04-16 17:13 ` [PATCH 5/8] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-04-17 12:51 ` Daniel Kiper
2013-04-18 16:29 ` David Vrabel
2013-04-19 8:08 ` Daniel Kiper
2013-02-21 17:48 [PATCH 0/8] kexec: extended kexec hypercall for use with pv-ops kernels David Vrabel
2013-02-21 17:48 ` [PATCH 5/8] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-02-21 22:41 ` Daniel Kiper
2013-03-08 11:23 ` Daniel Kiper
2013-03-08 11:40 ` David Vrabel
2013-03-08 12:21 ` Daniel Kiper
2013-03-08 14:01 ` David Vrabel
2013-03-08 15:23 ` Daniel Kiper
2013-03-12 11:36 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C4DD6.4020805@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox