From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1US5Yv-0005Rs-C8 for kexec@lists.infradead.org; Tue, 16 Apr 2013 13:04:42 +0000 Received: by mail-pb0-f49.google.com with SMTP id um15so283864pbc.22 for ; Tue, 16 Apr 2013 06:04:39 -0700 (PDT) Message-ID: <516D4C5F.4020905@gmail.com> Date: Tue, 16 Apr 2013 21:04:31 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH] Revert "kexec/powerpc: Handle buffer overflow in kernel command line" References: <516D4B35.3060300@gmail.com> In-Reply-To: <516D4B35.3060300@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Simon Horman Cc: "kexec@lists.infradead.org" SGkgU2ltb24sCgpJIGZvdW5kIHRoYXQgeW91IG1heSBhcHBseSB0aGUgcGF0Y2ggZnJvbSBTdXp1 a2kgd2l0aCBhIHdyb25nIGNvbW1pdApkZXNjcmlwdGlvbiBieSBtaXN0YWtlLiBTbyBJIHNlbmQg dGhpcyByZXZlcnQgcGF0Y2ggYW5kIHJlc2VuZCB0aGUKcGF0Y2ggaW4gYW5vdGhlciBtYWlsIHdp dGggYSBzdWJqZWN0OgogICAgIltQQVRDSCBSRVNFTkRdIGtleGVjL3Bvd2VycGM6IEhhbmRsZSBi dWZmZXIgb3ZlcmZsb3cgaW4ga2VybmVsIGNvbW1hbmQgbGluZSIKCkNvdWxkIHlvdSBwbGVhc2Ug YXBwbHkgdGhlIHR3byBwYXRjaGVzPwoKVGhhbmtzClpoYW5nCgrT2iAyMDEzxOowNNTCMTbI1SAy MDo1OSwgWmhhbmcgWWFuZmVpINC0tcA6Cj4gRnJvbTogWmhhbmcgWWFuZmVpIDx6aGFuZ3lhbmZl aUBjbi5mdWppdHN1LmNvbT4KPiAKPiBUaGlzIHJldmVydHMgY29tbWl0IGQ1OGRjYWUzZTYxYjM3 NTU3OGZmMzE0NWU2MjdhNWQ4NWFmYjVmNTIuCj4gCj4gVGhlIGNvbW1pdCBkZXNjcmlwdGlvbiBp cyBraW5kIG9mIHdyb25nIGFuZCBtYXliZSBjYXVzZWQgYnkgU2ltb24KPiB3aGVuIGhlIGFwcGxp ZWQgdGhlIHBhdGNoLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFpoYW5nIFlhbmZlaSA8emhhbmd5YW5m ZWlAY24uZnVqaXRzdS5jb20+Cj4gLS0tCj4gIGtleGVjL2FyY2gvcHBjL2tleGVjLWVsZi1wcGMu YyAgICB8ICAgMjkgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAga2V4ZWMvYXJjaC9w cGMva2V4ZWMtdUltYWdlLXBwYy5jIHwgICAyMyArKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAy IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDMwIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9rZXhlYy9hcmNoL3BwYy9rZXhlYy1lbGYtcHBjLmMgYi9rZXhlYy9hcmNoL3Bw Yy9rZXhlYy1lbGYtcHBjLmMKPiBpbmRleCA5OGNhZTljLi4zZGFjYTJkIDEwMDY0NAo+IC0tLSBh L2tleGVjL2FyY2gvcHBjL2tleGVjLWVsZi1wcGMuYwo+ICsrKyBiL2tleGVjL2FyY2gvcHBjL2tl eGVjLWVsZi1wcGMuYwo+IEBAIC0xNTcsNyArMTU3LDcgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQg YXJnYywgY2hhciAqKmFyZ3YsCWNvbnN0IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+ICAJc3RydWN0 IG1lbV9laGRyIGVoZHI7Cj4gIAljaGFyICpjb21tYW5kX2xpbmUsICpjcmFzaF9jbWRsaW5lLCAq Y21kbGluZV9idWY7Cj4gIAljaGFyICp0bXBfY21kbGluZTsKPiAtCWludCBjb21tYW5kX2xpbmVf bGVuLCBjcmFzaF9jbWRsaW5lX2xlbjsKPiArCWludCBjb21tYW5kX2xpbmVfbGVuOwo+ICAJY2hh ciAqZHRiOwo+ICAJaW50IHJlc3VsdDsKPiAgCWNoYXIgKmVycm9yX21zZzsKPiBAQCAtMjQ0LDEw ICsyNDQsMTkgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAqKmFyZ3YsCWNvbnN0 IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+ICAJfSBlbHNlIHsKPiAgCQljb21tYW5kX2xpbmUgPSBn ZXRfY29tbWFuZF9saW5lKCk7Cj4gIAl9Cj4gLQljb21tYW5kX2xpbmVfbGVuID0gc3RybGVuKGNv bW1hbmRfbGluZSk7Cj4gKwljb21tYW5kX2xpbmVfbGVuID0gc3RybGVuKGNvbW1hbmRfbGluZSkg KyAxOwo+ICAKPiAgCWZpeHVwX25vZGVzW2N1cl9maXh1cF0gPSBOVUxMOwo+ICAKPiArCS8qIE5l ZWQgdG8gYXBwZW5kIHNvbWUgY29tbWFuZCBsaW5lIHBhcmFtZXRlcnMgaW50ZXJuYWxseSBpbiBj YXNlIG9mCj4gKwkgKiB0YWtpbmcgY3Jhc2ggZHVtcHMuCj4gKwkgKi8KPiArCWlmIChpbmZvLT5r ZXhlY19mbGFncyAmIEtFWEVDX09OX0NSQVNIKSB7Cj4gKwkJY3Jhc2hfY21kbGluZSA9IHhtYWxs b2MoQ09NTUFORF9MSU5FX1NJWkUpOwo+ICsJCW1lbXNldCgodm9pZCAqKWNyYXNoX2NtZGxpbmUs IDAsIENPTU1BTkRfTElORV9TSVpFKTsKPiArCX0gZWxzZQo+ICsJCWNyYXNoX2NtZGxpbmUgPSBO VUxMOwo+ICsKPiAgCS8qIFBhcnNlIHRoZSBFbGYgZmlsZSAqLwo+ICAJcmVzdWx0ID0gYnVpbGRf ZWxmX2V4ZWNfaW5mbyhidWYsIGxlbiwgJmVoZHIsIDApOwo+ICAJaWYgKHJlc3VsdCA8IDApIHsK PiBAQCAtMjgzLDIzICsyOTIsMTYgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAq KmFyZ3YsCWNvbnN0IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+ ICAKPiAtCS8qCj4gLQkgKiBOZWVkIHRvIGFwcGVuZCBzb21lIGNvbW1hbmQgbGluZSBwYXJhbWV0 ZXJzIGludGVybmFsbHkgaW4gY2FzZSBvZgo+IC0JICogdGFraW5nIGNyYXNoIGR1bXBzLiBBZGRp dGlvbmFsIHNlZ21lbnRzIG5lZWQgdG8gYmUgY3JlYXRlZC4KPiArCS8qIElmIHBhbmljIGtlcm5l bCBpcyBiZWluZyBsb2FkZWQsIGFkZGl0aW9uYWwgc2VnbWVudHMgbmVlZAo+ICsJICogdG8gYmUg Y3JlYXRlZC4KPiAgCSAqLwo+ICAJaWYgKGluZm8tPmtleGVjX2ZsYWdzICYgS0VYRUNfT05fQ1JB U0gpIHsKPiAtCQljcmFzaF9jbWRsaW5lID0geG1hbGxvYyhDT01NQU5EX0xJTkVfU0laRSk7Cj4g LQkJbWVtc2V0KCh2b2lkICopY3Jhc2hfY21kbGluZSwgMCwgQ09NTUFORF9MSU5FX1NJWkUpOwo+ ICAJCXJlc3VsdCA9IGxvYWRfY3Jhc2hkdW1wX3NlZ21lbnRzKGluZm8sIGNyYXNoX2NtZGxpbmUs Cj4gIAkJCQkJCW1heF9hZGRyLCAwKTsKPiAgCQlpZiAocmVzdWx0IDwgMCkgewo+ICAJCQlyZXN1 bHQgPSAtMTsKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+IC0JCWNyYXNoX2NtZGxpbmVfbGVuID0g c3RybGVuKGNyYXNoX2NtZGxpbmUpOwo+IC0JfSBlbHNlIHsKPiAtCQljcmFzaF9jbWRsaW5lID0g TlVMTDsKPiAtCQljcmFzaF9jbWRsaW5lX2xlbiA9IDA7Cj4gIAl9Cj4gIAo+ICAJLyoKPiBAQCAt MzM1LDExICszMzcsNiBAQCBpbnQgZWxmX3BwY19sb2FkKGludCBhcmdjLCBjaGFyICoqYXJndiwJ Y29uc3QgY2hhciAqYnVmLCBvZmZfdCBsZW4sCj4gIAo+ICAJaW5mby0+ZW50cnkgPSAodm9pZCAq KWFyZ19iYXNlOwo+ICAjZWxzZQo+IC0JaWYgKGNyYXNoX2NtZGxpbmVfbGVuICsgY29tbWFuZF9s aW5lX2xlbiArIDEgPiBDT01NQU5EX0xJTkVfU0laRSkgewo+IC0JCXByaW50ZigiS2VybmVsIGNv bW1hbmQgbGluZSBleGNlZWRzIHNpemVcbiIpOwo+IC0JCXJldHVybiAtMTsKPiAtCX0KPiAtCj4g IAljbWRsaW5lX2J1ZiA9IHhtYWxsb2MoQ09NTUFORF9MSU5FX1NJWkUpOwo+ICAJbWVtc2V0KCh2 b2lkICopY21kbGluZV9idWYsIDAsIENPTU1BTkRfTElORV9TSVpFKTsKPiAgCWlmIChjb21tYW5k X2xpbmUpCj4gZGlmZiAtLWdpdCBhL2tleGVjL2FyY2gvcHBjL2tleGVjLXVJbWFnZS1wcGMuYyBi L2tleGVjL2FyY2gvcHBjL2tleGVjLXVJbWFnZS1wcGMuYwo+IGluZGV4IDAwODQ2M2IuLjkxMTNm YmUgMTAwNjQ0Cj4gLS0tIGEva2V4ZWMvYXJjaC9wcGMva2V4ZWMtdUltYWdlLXBwYy5jCj4gKysr IGIva2V4ZWMvYXJjaC9wcGMva2V4ZWMtdUltYWdlLXBwYy5jCj4gQEAgLTgyLDcgKzgyLDcgQEAg c3RhdGljIGludCBwcGNfbG9hZF9iYXJlX2JpdHMoaW50IGFyZ2MsIGNoYXIgKiphcmd2LCBjb25z dCBjaGFyICpidWYsCj4gIHsKPiAgCWNoYXIgKmNvbW1hbmRfbGluZSwgKmNtZGxpbmVfYnVmLCAq Y3Jhc2hfY21kbGluZTsKPiAgCWNoYXIgKnRtcF9jbWRsaW5lOwo+IC0JaW50IGNvbW1hbmRfbGlu ZV9sZW4sIGNyYXNoX2NtZGxpbmVfbGVuOwo+ICsJaW50IGNvbW1hbmRfbGluZV9sZW47Cj4gIAlj aGFyICpkdGI7Cj4gIAl1bnNpZ25lZCBpbnQgYWRkcjsKPiAgCXVuc2lnbmVkIGxvbmcgZHRiX2Fk ZHI7Cj4gQEAgLTE3OCwzNCArMTc4LDI5IEBAIHN0YXRpYyBpbnQgcHBjX2xvYWRfYmFyZV9iaXRz KGludCBhcmdjLCBjaGFyICoqYXJndiwgY29uc3QgY2hhciAqYnVmLAo+ICAKPiAgCWFkZF9zZWdt ZW50KGluZm8sIGJ1ZiwgbGVuLCBsb2FkX2FkZHIsIGxlbiArIF8xTWlCKTsKPiAgCj4gLQo+ICAJ aWYgKGluZm8tPmtleGVjX2ZsYWdzICYgS0VYRUNfT05fQ1JBU0gpIHsKPiAgICAgICAgICAgICAg ICAgIGNyYXNoX2NtZGxpbmUgPSB4bWFsbG9jKENPTU1BTkRfTElORV9TSVpFKTsKPiAgICAgICAg ICAgICAgICAgIG1lbXNldCgodm9pZCAqKWNyYXNoX2NtZGxpbmUsIDAsIENPTU1BTkRfTElORV9T SVpFKTsKPiArICAgICAgICB9IGVsc2UKPiArICAgICAgICAgICAgICAgIGNyYXNoX2NtZGxpbmUg PSBOVUxMOwo+ICsKPiArCWlmIChpbmZvLT5rZXhlY19mbGFncyAmIEtFWEVDX09OX0NSQVNIKSB7 Cj4gIAkJcmV0ID0gbG9hZF9jcmFzaGR1bXBfc2VnbWVudHMoaW5mbywgY3Jhc2hfY21kbGluZSwK PiAgCQkJCQkJbWF4X2FkZHIsIDApOwo+ICAJCWlmIChyZXQgPCAwKSB7Cj4gIAkJCXJldCA9IC0x Owo+ICAJCQlnb3RvIG91dDsKPiAgCQl9Cj4gLQkJY3Jhc2hfY21kbGluZV9sZW4gPSBzdHJsZW4o Y3Jhc2hfY21kbGluZSk7Cj4gLQl9IGVsc2Ugewo+IC0JCWNyYXNoX2NtZGxpbmUgPSBOVUxMOwo+ IC0JCWNyYXNoX2NtZGxpbmVfbGVuID0gMDsKPiAtCX0KPiAtCj4gLQlpZiAoY3Jhc2hfY21kbGlu ZV9sZW4gKyBjb21tYW5kX2xpbmVfbGVuICsgMSA+IENPTU1BTkRfTElORV9TSVpFKSB7Cj4gLQkJ cHJpbnRmKCJLZXJuZWwgY29tbWFuZCBsaW5lIGV4Y2VlZHMgbWF4aW11bSBwb3NzaWJsZSBsZW5n dGhcbiIpOwo+IC0JCXJldHVybiAtMTsKPiAgCX0KPiAgCj4gIAljbWRsaW5lX2J1ZiA9IHhtYWxs b2MoQ09NTUFORF9MSU5FX1NJWkUpOwo+ICAJbWVtc2V0KCh2b2lkICopY21kbGluZV9idWYsIDAs IENPTU1BTkRfTElORV9TSVpFKTsKPiAtCj4gIAlpZiAoY29tbWFuZF9saW5lKQo+IC0JCXN0cmNw eShjbWRsaW5lX2J1ZiwgY29tbWFuZF9saW5lKTsKPiArCQlzdHJuY2F0KGNtZGxpbmVfYnVmLCBj b21tYW5kX2xpbmUsIGNvbW1hbmRfbGluZV9sZW4pOwo+ICAJaWYgKGNyYXNoX2NtZGxpbmUpCj4g LQkJc3RybmNhdChjbWRsaW5lX2J1ZiwgY3Jhc2hfY21kbGluZSwgY3Jhc2hfY21kbGluZV9sZW4p Owo+ICsJCXN0cm5jYXQoY21kbGluZV9idWYsIGNyYXNoX2NtZGxpbmUsCj4gKwkJCXNpemVvZihj cmFzaF9jbWRsaW5lKSAtCj4gKwkJCXN0cmxlbihjcmFzaF9jbWRsaW5lKSAtIDEpOwo+ICAKPiAg CWVsZl9yZWxfYnVpbGRfbG9hZChpbmZvLCAmaW5mby0+cmhkciwgKGNvbnN0IGNoYXIgKilwdXJn YXRvcnksCj4gIAkJCQlwdXJnYXRvcnlfc2l6ZSwgMCwgLTEsIC0xLCAwKTsKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QK a2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2tleGVjCg==