From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pd0-f176.google.com ([209.85.192.176]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1US6Ua-0006kf-1u for kexec@lists.infradead.org; Tue, 16 Apr 2013 14:04:17 +0000 Received: by mail-pd0-f176.google.com with SMTP id r11so307765pdi.35 for ; Tue, 16 Apr 2013 07:04:12 -0700 (PDT) Message-ID: <516D5A51.6040507@gmail.com> Date: Tue, 16 Apr 2013 22:04:01 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH] Revert "kexec/powerpc: Handle buffer overflow in kernel command line" References: <516D4B35.3060300@gmail.com> <516D4C5F.4020905@gmail.com> <20130416135429.GA4476@verge.net.au> In-Reply-To: <20130416135429.GA4476@verge.net.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Simon Horman Cc: "kexec@lists.infradead.org" 5LqOIDIwMTPlubQwNOaciDE25pelIDIxOjU0LCBTaW1vbiBIb3JtYW4g5YaZ6YGTOgo+IE9uIFR1 ZSwgQXByIDE2LCAyMDEzIGF0IDA5OjA0OjMxUE0gKzA4MDAsIFpoYW5nIFlhbmZlaSB3cm90ZToK Pj4gSGkgU2ltb24sCj4+Cj4+IEkgZm91bmQgdGhhdCB5b3UgbWF5IGFwcGx5IHRoZSBwYXRjaCBm cm9tIFN1enVraSB3aXRoIGEgd3JvbmcgY29tbWl0Cj4+IGRlc2NyaXB0aW9uIGJ5IG1pc3Rha2Uu IFNvIEkgc2VuZCB0aGlzIHJldmVydCBwYXRjaCBhbmQgcmVzZW5kIHRoZQo+PiBwYXRjaCBpbiBh bm90aGVyIG1haWwgd2l0aCBhIHN1YmplY3Q6Cj4+ICAgICAiW1BBVENIIFJFU0VORF0ga2V4ZWMv cG93ZXJwYzogSGFuZGxlIGJ1ZmZlciBvdmVyZmxvdyBpbiBrZXJuZWwgY29tbWFuZCBsaW5lIgo+ Pgo+PiBDb3VsZCB5b3UgcGxlYXNlIGFwcGx5IHRoZSB0d28gcGF0Y2hlcz8KPiAKPiBTb3JyeSBm b3IgbXkgY2FyZWxlc3NuZXNzLgo+IAo+IEkgaGF2ZSByZW1vdmVkIHRoZSBwYXRjaCBJIGFwcGxp ZWQgZWFybGllciB0b2RheSwgYXBwbGllZCB0aGUKPiBvbmUgeW91IHBvc3RlZCBhZnRlciB0aGlz IG9uZSBhbmQgZm9yY2libHkgcHVzaGVkIHRoZSByZXN1bHQuCj4gCgpPSy4gTm93IGl0IGlzIG9r LgoKVGhhbmtzClpoYW5nCgo+Pgo+PiBUaGFua3MKPj4gWmhhbmcKPj4KPj4g5LqOIDIwMTPlubQw NOaciDE25pelIDIwOjU5LCBaaGFuZyBZYW5mZWkg5YaZ6YGTOgo+Pj4gRnJvbTogWmhhbmcgWWFu ZmVpIDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KPj4+Cj4+PiBUaGlzIHJldmVydHMgY29t bWl0IGQ1OGRjYWUzZTYxYjM3NTU3OGZmMzE0NWU2MjdhNWQ4NWFmYjVmNTIuCj4+Pgo+Pj4gVGhl IGNvbW1pdCBkZXNjcmlwdGlvbiBpcyBraW5kIG9mIHdyb25nIGFuZCBtYXliZSBjYXVzZWQgYnkg U2ltb24KPj4+IHdoZW4gaGUgYXBwbGllZCB0aGUgcGF0Y2guCj4+Pgo+Pj4gU2lnbmVkLW9mZi1i eTogWmhhbmcgWWFuZmVpIDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KPj4+IC0tLQo+Pj4g IGtleGVjL2FyY2gvcHBjL2tleGVjLWVsZi1wcGMuYyAgICB8ICAgMjkgKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0KPj4+ICBrZXhlYy9hcmNoL3BwYy9rZXhlYy11SW1hZ2UtcHBjLmMgfCAg IDIzICsrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNl cnRpb25zKCspLCAzMCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEva2V4ZWMvYXJj aC9wcGMva2V4ZWMtZWxmLXBwYy5jIGIva2V4ZWMvYXJjaC9wcGMva2V4ZWMtZWxmLXBwYy5jCj4+ PiBpbmRleCA5OGNhZTljLi4zZGFjYTJkIDEwMDY0NAo+Pj4gLS0tIGEva2V4ZWMvYXJjaC9wcGMv a2V4ZWMtZWxmLXBwYy5jCj4+PiArKysgYi9rZXhlYy9hcmNoL3BwYy9rZXhlYy1lbGYtcHBjLmMK Pj4+IEBAIC0xNTcsNyArMTU3LDcgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAq KmFyZ3YsCWNvbnN0IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+Pj4gIAlzdHJ1Y3QgbWVtX2VoZHIg ZWhkcjsKPj4+ICAJY2hhciAqY29tbWFuZF9saW5lLCAqY3Jhc2hfY21kbGluZSwgKmNtZGxpbmVf YnVmOwo+Pj4gIAljaGFyICp0bXBfY21kbGluZTsKPj4+IC0JaW50IGNvbW1hbmRfbGluZV9sZW4s IGNyYXNoX2NtZGxpbmVfbGVuOwo+Pj4gKwlpbnQgY29tbWFuZF9saW5lX2xlbjsKPj4+ICAJY2hh ciAqZHRiOwo+Pj4gIAlpbnQgcmVzdWx0Owo+Pj4gIAljaGFyICplcnJvcl9tc2c7Cj4+PiBAQCAt MjQ0LDEwICsyNDQsMTkgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAqKmFyZ3Ys CWNvbnN0IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+Pj4gIAl9IGVsc2Ugewo+Pj4gIAkJY29tbWFu ZF9saW5lID0gZ2V0X2NvbW1hbmRfbGluZSgpOwo+Pj4gIAl9Cj4+PiAtCWNvbW1hbmRfbGluZV9s ZW4gPSBzdHJsZW4oY29tbWFuZF9saW5lKTsKPj4+ICsJY29tbWFuZF9saW5lX2xlbiA9IHN0cmxl bihjb21tYW5kX2xpbmUpICsgMTsKPj4+ICAKPj4+ICAJZml4dXBfbm9kZXNbY3VyX2ZpeHVwXSA9 IE5VTEw7Cj4+PiAgCj4+PiArCS8qIE5lZWQgdG8gYXBwZW5kIHNvbWUgY29tbWFuZCBsaW5lIHBh cmFtZXRlcnMgaW50ZXJuYWxseSBpbiBjYXNlIG9mCj4+PiArCSAqIHRha2luZyBjcmFzaCBkdW1w cy4KPj4+ICsJICovCj4+PiArCWlmIChpbmZvLT5rZXhlY19mbGFncyAmIEtFWEVDX09OX0NSQVNI KSB7Cj4+PiArCQljcmFzaF9jbWRsaW5lID0geG1hbGxvYyhDT01NQU5EX0xJTkVfU0laRSk7Cj4+ PiArCQltZW1zZXQoKHZvaWQgKiljcmFzaF9jbWRsaW5lLCAwLCBDT01NQU5EX0xJTkVfU0laRSk7 Cj4+PiArCX0gZWxzZQo+Pj4gKwkJY3Jhc2hfY21kbGluZSA9IE5VTEw7Cj4+PiArCj4+PiAgCS8q IFBhcnNlIHRoZSBFbGYgZmlsZSAqLwo+Pj4gIAlyZXN1bHQgPSBidWlsZF9lbGZfZXhlY19pbmZv KGJ1ZiwgbGVuLCAmZWhkciwgMCk7Cj4+PiAgCWlmIChyZXN1bHQgPCAwKSB7Cj4+PiBAQCAtMjgz LDIzICsyOTIsMTYgQEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAqKmFyZ3YsCWNv bnN0IGNoYXIgKmJ1Ziwgb2ZmX3QgbGVuLAo+Pj4gIAkJZ290byBvdXQ7Cj4+PiAgCX0KPj4+ICAK Pj4+IC0JLyoKPj4+IC0JICogTmVlZCB0byBhcHBlbmQgc29tZSBjb21tYW5kIGxpbmUgcGFyYW1l dGVycyBpbnRlcm5hbGx5IGluIGNhc2Ugb2YKPj4+IC0JICogdGFraW5nIGNyYXNoIGR1bXBzLiBB ZGRpdGlvbmFsIHNlZ21lbnRzIG5lZWQgdG8gYmUgY3JlYXRlZC4KPj4+ICsJLyogSWYgcGFuaWMg a2VybmVsIGlzIGJlaW5nIGxvYWRlZCwgYWRkaXRpb25hbCBzZWdtZW50cyBuZWVkCj4+PiArCSAq IHRvIGJlIGNyZWF0ZWQuCj4+PiAgCSAqLwo+Pj4gIAlpZiAoaW5mby0+a2V4ZWNfZmxhZ3MgJiBL RVhFQ19PTl9DUkFTSCkgewo+Pj4gLQkJY3Jhc2hfY21kbGluZSA9IHhtYWxsb2MoQ09NTUFORF9M SU5FX1NJWkUpOwo+Pj4gLQkJbWVtc2V0KCh2b2lkICopY3Jhc2hfY21kbGluZSwgMCwgQ09NTUFO RF9MSU5FX1NJWkUpOwo+Pj4gIAkJcmVzdWx0ID0gbG9hZF9jcmFzaGR1bXBfc2VnbWVudHMoaW5m bywgY3Jhc2hfY21kbGluZSwKPj4+ICAJCQkJCQltYXhfYWRkciwgMCk7Cj4+PiAgCQlpZiAocmVz dWx0IDwgMCkgewo+Pj4gIAkJCXJlc3VsdCA9IC0xOwo+Pj4gIAkJCWdvdG8gb3V0Owo+Pj4gIAkJ fQo+Pj4gLQkJY3Jhc2hfY21kbGluZV9sZW4gPSBzdHJsZW4oY3Jhc2hfY21kbGluZSk7Cj4+PiAt CX0gZWxzZSB7Cj4+PiAtCQljcmFzaF9jbWRsaW5lID0gTlVMTDsKPj4+IC0JCWNyYXNoX2NtZGxp bmVfbGVuID0gMDsKPj4+ICAJfQo+Pj4gIAo+Pj4gIAkvKgo+Pj4gQEAgLTMzNSwxMSArMzM3LDYg QEAgaW50IGVsZl9wcGNfbG9hZChpbnQgYXJnYywgY2hhciAqKmFyZ3YsCWNvbnN0IGNoYXIgKmJ1 Ziwgb2ZmX3QgbGVuLAo+Pj4gIAo+Pj4gIAlpbmZvLT5lbnRyeSA9ICh2b2lkICopYXJnX2Jhc2U7 Cj4+PiAgI2Vsc2UKPj4+IC0JaWYgKGNyYXNoX2NtZGxpbmVfbGVuICsgY29tbWFuZF9saW5lX2xl biArIDEgPiBDT01NQU5EX0xJTkVfU0laRSkgewo+Pj4gLQkJcHJpbnRmKCJLZXJuZWwgY29tbWFu ZCBsaW5lIGV4Y2VlZHMgc2l6ZVxuIik7Cj4+PiAtCQlyZXR1cm4gLTE7Cj4+PiAtCX0KPj4+IC0K Pj4+ICAJY21kbGluZV9idWYgPSB4bWFsbG9jKENPTU1BTkRfTElORV9TSVpFKTsKPj4+ICAJbWVt c2V0KCh2b2lkICopY21kbGluZV9idWYsIDAsIENPTU1BTkRfTElORV9TSVpFKTsKPj4+ICAJaWYg KGNvbW1hbmRfbGluZSkKPj4+IGRpZmYgLS1naXQgYS9rZXhlYy9hcmNoL3BwYy9rZXhlYy11SW1h Z2UtcHBjLmMgYi9rZXhlYy9hcmNoL3BwYy9rZXhlYy11SW1hZ2UtcHBjLmMKPj4+IGluZGV4IDAw ODQ2M2IuLjkxMTNmYmUgMTAwNjQ0Cj4+PiAtLS0gYS9rZXhlYy9hcmNoL3BwYy9rZXhlYy11SW1h Z2UtcHBjLmMKPj4+ICsrKyBiL2tleGVjL2FyY2gvcHBjL2tleGVjLXVJbWFnZS1wcGMuYwo+Pj4g QEAgLTgyLDcgKzgyLDcgQEAgc3RhdGljIGludCBwcGNfbG9hZF9iYXJlX2JpdHMoaW50IGFyZ2Ms IGNoYXIgKiphcmd2LCBjb25zdCBjaGFyICpidWYsCj4+PiAgewo+Pj4gIAljaGFyICpjb21tYW5k X2xpbmUsICpjbWRsaW5lX2J1ZiwgKmNyYXNoX2NtZGxpbmU7Cj4+PiAgCWNoYXIgKnRtcF9jbWRs aW5lOwo+Pj4gLQlpbnQgY29tbWFuZF9saW5lX2xlbiwgY3Jhc2hfY21kbGluZV9sZW47Cj4+PiAr CWludCBjb21tYW5kX2xpbmVfbGVuOwo+Pj4gIAljaGFyICpkdGI7Cj4+PiAgCXVuc2lnbmVkIGlu dCBhZGRyOwo+Pj4gIAl1bnNpZ25lZCBsb25nIGR0Yl9hZGRyOwo+Pj4gQEAgLTE3OCwzNCArMTc4 LDI5IEBAIHN0YXRpYyBpbnQgcHBjX2xvYWRfYmFyZV9iaXRzKGludCBhcmdjLCBjaGFyICoqYXJn diwgY29uc3QgY2hhciAqYnVmLAo+Pj4gIAo+Pj4gIAlhZGRfc2VnbWVudChpbmZvLCBidWYsIGxl biwgbG9hZF9hZGRyLCBsZW4gKyBfMU1pQik7Cj4+PiAgCj4+PiAtCj4+PiAgCWlmIChpbmZvLT5r ZXhlY19mbGFncyAmIEtFWEVDX09OX0NSQVNIKSB7Cj4+PiAgICAgICAgICAgICAgICAgIGNyYXNo X2NtZGxpbmUgPSB4bWFsbG9jKENPTU1BTkRfTElORV9TSVpFKTsKPj4+ICAgICAgICAgICAgICAg ICAgbWVtc2V0KCh2b2lkICopY3Jhc2hfY21kbGluZSwgMCwgQ09NTUFORF9MSU5FX1NJWkUpOwo+ Pj4gKyAgICAgICAgfSBlbHNlCj4+PiArICAgICAgICAgICAgICAgIGNyYXNoX2NtZGxpbmUgPSBO VUxMOwo+Pj4gKwo+Pj4gKwlpZiAoaW5mby0+a2V4ZWNfZmxhZ3MgJiBLRVhFQ19PTl9DUkFTSCkg ewo+Pj4gIAkJcmV0ID0gbG9hZF9jcmFzaGR1bXBfc2VnbWVudHMoaW5mbywgY3Jhc2hfY21kbGlu ZSwKPj4+ICAJCQkJCQltYXhfYWRkciwgMCk7Cj4+PiAgCQlpZiAocmV0IDwgMCkgewo+Pj4gIAkJ CXJldCA9IC0xOwo+Pj4gIAkJCWdvdG8gb3V0Owo+Pj4gIAkJfQo+Pj4gLQkJY3Jhc2hfY21kbGlu ZV9sZW4gPSBzdHJsZW4oY3Jhc2hfY21kbGluZSk7Cj4+PiAtCX0gZWxzZSB7Cj4+PiAtCQljcmFz aF9jbWRsaW5lID0gTlVMTDsKPj4+IC0JCWNyYXNoX2NtZGxpbmVfbGVuID0gMDsKPj4+IC0JfQo+ Pj4gLQo+Pj4gLQlpZiAoY3Jhc2hfY21kbGluZV9sZW4gKyBjb21tYW5kX2xpbmVfbGVuICsgMSA+ IENPTU1BTkRfTElORV9TSVpFKSB7Cj4+PiAtCQlwcmludGYoIktlcm5lbCBjb21tYW5kIGxpbmUg ZXhjZWVkcyBtYXhpbXVtIHBvc3NpYmxlIGxlbmd0aFxuIik7Cj4+PiAtCQlyZXR1cm4gLTE7Cj4+ PiAgCX0KPj4+ICAKPj4+ICAJY21kbGluZV9idWYgPSB4bWFsbG9jKENPTU1BTkRfTElORV9TSVpF KTsKPj4+ICAJbWVtc2V0KCh2b2lkICopY21kbGluZV9idWYsIDAsIENPTU1BTkRfTElORV9TSVpF KTsKPj4+IC0KPj4+ICAJaWYgKGNvbW1hbmRfbGluZSkKPj4+IC0JCXN0cmNweShjbWRsaW5lX2J1 ZiwgY29tbWFuZF9saW5lKTsKPj4+ICsJCXN0cm5jYXQoY21kbGluZV9idWYsIGNvbW1hbmRfbGlu ZSwgY29tbWFuZF9saW5lX2xlbik7Cj4+PiAgCWlmIChjcmFzaF9jbWRsaW5lKQo+Pj4gLQkJc3Ry bmNhdChjbWRsaW5lX2J1ZiwgY3Jhc2hfY21kbGluZSwgY3Jhc2hfY21kbGluZV9sZW4pOwo+Pj4g KwkJc3RybmNhdChjbWRsaW5lX2J1ZiwgY3Jhc2hfY21kbGluZSwKPj4+ICsJCQlzaXplb2YoY3Jh c2hfY21kbGluZSkgLQo+Pj4gKwkJCXN0cmxlbihjcmFzaF9jbWRsaW5lKSAtIDEpOwo+Pj4gIAo+ Pj4gIAllbGZfcmVsX2J1aWxkX2xvYWQoaW5mbywgJmluZm8tPnJoZHIsIChjb25zdCBjaGFyICop cHVyZ2F0b3J5LAo+Pj4gIAkJCQlwdXJnYXRvcnlfc2l6ZSwgMCwgLTEsIC0xLCAwKTsKPj4KCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWls aW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg==