public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei.yes@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return
Date: Sun, 26 May 2013 18:02:37 +0800	[thread overview]
Message-ID: <51A1DDBD.3020507@gmail.com> (raw)

From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

The return will never be reached, so remove it.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 kexec/arch/ppc/kexec-ppc.c     |    1 -
 kexec/arch/ppc64/kexec-ppc64.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kexec/arch/ppc/kexec-ppc.c b/kexec/arch/ppc/kexec-ppc.c
index 5a2966e..d046110 100644
--- a/kexec/arch/ppc/kexec-ppc.c
+++ b/kexec/arch/ppc/kexec-ppc.c
@@ -736,7 +736,6 @@ static int get_devtree_details(unsigned long kexec_flags)
 					!= 1) {
 				perror(fname);
 				goto error_openfile;
-				return -1;
 			}
 			memset(fname, 0, sizeof(fname));
 			sprintf(fname, "%s%s%s",
diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
index 389741a..21bd0a8 100644
--- a/kexec/arch/ppc64/kexec-ppc64.c
+++ b/kexec/arch/ppc64/kexec-ppc64.c
@@ -590,7 +590,6 @@ static int get_devtree_details(unsigned long kexec_flags)
 			if (fread(&tce_base, sizeof(uint64_t), 1, file) != 1) {
 				perror(fname);
 				goto error_openfile;
-				return -1;
 			}
 			memset(fname, 0, sizeof(fname));
 			strcpy(fname, device_tree);
-- 
1.7.1

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2013-05-26 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-26 10:02 Zhang Yanfei [this message]
2013-05-26 13:34 ` [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A1DDBD.3020507@gmail.com \
    --to=zhangyanfei.yes@gmail.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox