Re: [PATCH] makedumpfile: add missing options to man page or help

[Baoquan He <bhe@redhat.com>]

On 06/21/2013 04:23 PM, Jingbai Ma wrote:
>>>>>>
>>>>>> One of my solution is conversely to delete short options, and I don't
>>>>>> think it problem because the short options are only implicitly
>>>>>> exported
>>>>>> without explicit description on such as manual page and help message.
>>>>>
>>>>>
>>>>> Yeah, deleting short options is also a good method, let's wait and see
>>>>> what the maintainer say.
>>>>
>>>> I agree to delete short options.
>>>> Could you re-send the patch ?
>>>>
>>>
>>> BTW, we can assign non-printable characters as short options. Normally
>>> we don't type non-printable characters on console, so it's for free.
>>>
>>
>> Hi,
>> I think it's good idea. In kexec, some options use below short option
>> with a large value. With these indicative MACRO as short option, it will
>> make code more readable.
>>
>> Then all old short options can be replaced with them.
>>
>> #define OPT_MEM_MIN             256
>> #define OPT_MEM_MAX             257
>> #define OPT_REUSE_INITRD        258
>> #define OPT_LOAD_PRESERVE_CONTEXT 259
>> #define OPT_LOAD_JUMP_BACK_HELPER 260
>> #define OPT_ENTRY               261
>> #define OPT_MAX                 262
>>
> 
> But the value of char should only be from 0 to 255, so the value 256 to
> 262 couldn't be mapped to a single char.

As above discussion, printable short option is not needed, then it's
unnecessary to map value to a single char. Using short option just for
implementation.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec