From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <51E958CC.5070906@wwwdotorg.org> Date: Fri, 19 Jul 2013 09:18:36 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH] ARM: kexec: validate CPU hotplug support References: <1373582931-11956-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1373582931-11956-1-git-send-email-swarren@wwwdotorg.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Russell King Cc: Stephen Warren , kexec@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, Simon Horman , ebiederm@xmission.com, linux-arm-kernel@lists.infradead.org On 07/11/2013 04:48 PM, Stephen Warren wrote: > From: Stephen Warren > > Architectures should fully validate whether kexec is possible as part of > machine_kexec_prepare(), so that user-space's kexec_load() operation can > report any problems. Performing validation in machine_kexec() itself is > too late, since it is not allowed to return. > > Prior to this patch, ARM's machine_kexec() was testing after-the-fact > whether machine_kexec_prepare() was able to disable all but one CPU. > Instead, modify machine_kexec_prepare() to validate all conditions > necessary for machine_kexec_prepare()'s to succeed. BUG if the validation > succeeded, yet disabling the CPUs didn't actually work. Russell, does this look good to put into the ARM patch tracker? _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec