public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
To: d.hatayama@jp.fujitsu.com, cpw@sgi.com
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] makedumpfile: use non-cyclic when possible
Date: Mon, 09 Sep 2013 16:55:08 +0900	[thread overview]
Message-ID: <522D7EDC.8070906@mxc.nes.nec.co.jp> (raw)
In-Reply-To: <521FE9BC.1090109@jp.fujitsu.com>

(2013/08/30 9:40), HATAYAMA Daisuke wrote:
> (2013/08/29 7:08), Cliff Wickman wrote:
>> From: Cliff Wickman <cpw@sgi.com>
>>
>> If there is plenty of memory use non-cyclic mode.
>>
> 
> If there is enough memory to use, the number of cycle is 1.
> Cyclic mode in 1-cycle is the same as non-cyclic mode in theory.
> If slow, it's better to improve cyclic mode implementation.
> 
> To be honest, I think the current non-cyclic mode should be implemented as 1-cycle case. 
> Then, makedumpfile can reduce amount of code at the same time. 

Yes, I hope to get rid of non-cyclic mode.
When v1.5.0 was released, I retained non-cyclic mode as just
workaround since cyclic mode has big performance issue.
However, we have done some improvement for cyclic mode and
we will continue it.

So please don't make the code depend on non-cyclic mode and
make efforts to get rid of it.


Thanks
Atsushi Kumagai

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2013-09-09  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 22:08 [PATCH] makedumpfile: use non-cyclic when possible Cliff Wickman
2013-08-30  0:39 ` HATAYAMA Daisuke
2013-09-09  7:55   ` Atsushi Kumagai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522D7EDC.8070906@mxc.nes.nec.co.jp \
    --to=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=cpw@sgi.com \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox