Re: [PATCH 0/3] drm/radeon kexec fixes

Eric W. Biederman
2013-09-09T00:33:33Z

Markus Trippelsdorf <markus@trippelsdorf.de> writes:

> Here are a couple of patches that get kexec working with radeon devices.
> I've tested this on my RS780.
> Comments or flames are welcome.
> Thanks.

A couple of high level comments.

This looks promising for the usual case.

Removing the printk at the end of the kexec path seems a little dubious,
what of other cpus, interrupt handlers, etc. Basically estabilishing a
new rule on when printk is allowed seems a little dubious at this point,
even if it is a useful debugging trick.

Having a clean shutdown of the radeon definitely seems worth doing,
because the cases where we care abouty video are when a person is in
front of the system.

I don't know if you want to remove the sanity checks. They seem cheap
and safe regardless. Are they expensive or ineffective? Moreover if
they work a reasonable amount of the time that means that the kexec on
panic case (where we don't shut anything down) can actually use the
video, and that in general the driver will be more robust. I don't
expect anyone much cares as kexec on panic is mostly used to just write
a core file to the network, or the local disk. But if it is easy to
keep that case working most of the time, why not.

Eric

> Markus Trippelsdorf (3):
> kexec: get rid of late printk
> drm/radeon: Implement radeon_pci_shutdown
> drm/radeon: get rid of r100_restore_sanity hack
>
> drivers/gpu/drm/radeon/r100.c | 27 ---------------------------
> drivers/gpu/drm/radeon/r300.c | 2 --
> drivers/gpu/drm/radeon/r420.c | 2 --
> drivers/gpu/drm/radeon/r520.c | 2 --
> drivers/gpu/drm/radeon/radeon_asic.h | 1 -
> drivers/gpu/drm/radeon/radeon_drv.c | 10 ++++++++++
> drivers/gpu/drm/radeon/rs400.c | 2 --
> drivers/gpu/drm/radeon/rs600.c | 2 --
> drivers/gpu/drm/radeon/rs690.c | 2 --
> drivers/gpu/drm/radeon/rv515.c | 2 --
> kernel/kexec.c | 1 -
> 11 files changed, 10 insertions(+), 43 deletions(-)