From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Dave Anderson <anderson@redhat.com>
Cc: Baoquan He <bhe@redhat.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
usui@mxm.nes.nec.co.jp, lisa mitchell <lisa.mitchell@hp.com>,
RuiRui Yang <ruyang@redhat.com>,
Masaki Tachibana <tachibana@mxm.nes.nec.co.jp>,
kumagai-atsushi <kumagai-atsushi@mxc.nes.nec.co.jp>,
WANG Chao <chaowang@redhat.com>,
kexec@lists.infradead.org, Vivek Goyal <vgoyal@redhat.com>,
"Discussion list for crash utility usage,
maintenance and development" <crash-utility@redhat.com>
Subject: Re: [BUG] [compressed kdump / SADUMP] makedumpfile header truncation error
Date: Tue, 17 Sep 2013 15:41:05 +0900 [thread overview]
Message-ID: <5237F981.9060305@jp.fujitsu.com> (raw)
In-Reply-To: <131560856.13730586.1379360704169.JavaMail.root@redhat.com>
(2013/09/17 4:45), Dave Anderson wrote:
<cut>
> The 32-bit field has also been carried forward into the SADUMP header
> as well, which has this in "sadump_mod.h":
>
> struct sadump_header {
> ...
> uint32_t max_mapnr; /* = max_mapnr */
> ...
>
> And when these header structures change, the crash utility will need
> to be changed accordingly.
>
> Preferably for backwards-compatibility, a new header_version can be
> created, with the new expanded field located in the kdump_sub_header
> so that the original base structure can remain as-is. But I leave that
> up to the maintainers.
>
> Thanks,
> Dave
>
Thanks for pointing out that, Dave.
In fact, I've already noticed that. However, 32 bit unsigned integer can
still represent at most 16 TiB memory and FJ doesn't have system with more
than 16 TiB memory.
However, some FJ system will soon have larger memory and then sadump
will and must have new format that contains the corresponding improvement.
Then, I post the corresponding patch to crash utility and makedumpfile.
--
Thanks.
HATAYAMA, Daisuke
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2013-09-17 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50924626.13720007.1379359322944.JavaMail.root@redhat.com>
2013-09-16 19:45 ` [BUG] [compressed kdump / SADUMP] makedumpfile header truncation error Dave Anderson
2013-09-17 4:36 ` Jingbai Ma
2013-09-17 6:55 ` HATAYAMA Daisuke
2013-09-17 7:12 ` Jingbai Ma
2013-09-17 7:33 ` HATAYAMA Daisuke
2013-09-17 8:21 ` Jingbai Ma
2013-09-17 13:23 ` Dave Anderson
2013-09-18 10:30 ` Jingbai Ma
2013-09-18 14:17 ` Dave Anderson
2013-09-19 12:55 ` Ma, Jingbai (Kingboard)
2013-09-19 13:07 ` Ma, Jingbai (Kingboard)
2013-09-17 6:41 ` HATAYAMA Daisuke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5237F981.9060305@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=chaowang@redhat.com \
--cc=crash-utility@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=lisa.mitchell@hp.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=ruyang@redhat.com \
--cc=tachibana@mxm.nes.nec.co.jp \
--cc=usui@mxm.nes.nec.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox