Re: [BUG] [compressed kdump / SADUMP] makedumpfile header truncation error

HATAYAMA Daisuke
2013-09-17T06:42:00Z

(2013/09/17 4:45), Dave Anderson wrote:
<cut>
> The 32-bit field has also been carried forward into the SADUMP header
> as well, which has this in "sadump_mod.h":
>
> struct sadump_header {
> ...
> uint32_t max_mapnr; /* = max_mapnr */
> ...
>
> And when these header structures change, the crash utility will need
> to be changed accordingly.
>
> Preferably for backwards-compatibility, a new header_version can be
> created, with the new expanded field located in the kdump_sub_header
> so that the original base structure can remain as-is. But I leave that
> up to the maintainers.
>
> Thanks,
> Dave
>

Thanks for pointing out that, Dave.

In fact, I've already noticed that. However, 32 bit unsigned integer can
still represent at most 16 TiB memory and FJ doesn't have system with more
than 16 TiB memory.

However, some FJ system will soon have larger memory and then sadump
will and must have new format that contains the corresponding improvement.
Then, I post the corresponding patch to crash utility and makedumpfile.

--
Thanks.
HATAYAMA, Daisuke