From: Taras Kondratiuk <taras.kondratiuk@linaro.org>
To: Simon Horman <horms@verge.net.au>, WANG Chao <chaowang@redhat.com>
Cc: Joe Perches <joe@perches.com>, Lubomir Rintel <lkundrak@v3.sk>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2] vmcore-dmesg: Understand >= v3.11-rc4 dmesg
Date: Thu, 31 Oct 2013 09:42:32 -0700 [thread overview]
Message-ID: <52728878.2080302@linaro.org> (raw)
In-Reply-To: <20131031062026.GX1603@verge.net.au>
On 10/30/2013 11:20 PM, Simon Horman wrote:
> On Thu, Oct 31, 2013 at 01:38:08PM +0800, WANG Chao wrote:
>> On 10/30/13 at 06:06pm, Lubomir Rintel wrote:
>>> Hi,
>>>
>>> On Wed, 2013-10-30 at 11:12 +0800, WANG Chao wrote:
>>>> On 09/19/13 at 04:49pm, Lubomir Rintel wrote:
>>>>> Symbol name changed with the following commit:
>>>>> 62e32ac printk: rename struct log to struct printk_log
>>> ...
>>>> vmcore-dmesg is really broken here since 3.11 kernel is released. Are
>>>> you going to send an update v3 to address the comments to v2 from Vivek,
>>>> Joe and Dave
>>>
>>> I'm not really sure. I thought the suggestions were concerning the Linux
>>> kernel tree, not kexec-tools tree. I might be wrong though, but I'd need
>>> the suggestions to be a bit more specific for me to understand.
>>
>> That wouldn't be your concern any more. I think your patch is fine.
>> Thank you for fix.
>>
>> Hi Simon,
>>
>> Will you pick up this patch? Vivek and Dave has acked this patch.
>> And also this patch works for me.
>
> Sure. Please repost it with the Acks.
I have concerns about this patch.
There were a lot of hardcoded lenght values in the original code.
Now there are twice as much and we need to keep adding hardcoded
values if any additional parameter should be read of renamed.
Please eveluate this patch [1]. It should remove both:
hardcoded values and duplicated reading for two buffer names.
[1] http://permalink.gmane.org/gmane.linux.kernel.kexec/9522
--
Taras Kondratiuk
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-10-31 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 12:21 [RESEND PATCH] vmcore-dmesg: Understand >= v3.11-rc4 dmesg Lubomir Rintel
2013-09-19 14:38 ` Dave Young
2013-09-19 14:49 ` [PATCH v2] " Lubomir Rintel
2013-09-20 1:50 ` Dave Young
2013-09-20 1:55 ` Joe Perches
2013-09-20 7:40 ` Dave Young
2013-09-23 17:03 ` Vivek Goyal
2013-10-30 3:12 ` WANG Chao
2013-10-30 17:06 ` Lubomir Rintel
2013-10-31 0:34 ` Taras Kondratiuk
2013-10-31 5:38 ` WANG Chao
2013-10-31 6:18 ` WANG Chao
2013-10-31 6:20 ` Simon Horman
2013-10-31 16:42 ` Taras Kondratiuk [this message]
2013-11-01 0:32 ` Simon Horman
2014-05-22 13:51 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52728878.2080302@linaro.org \
--to=taras.kondratiuk@linaro.org \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=joe@perches.com \
--cc=kexec@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox