From: Wang Nan <wangnan0@huawei.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: "horms@verge.net.au" <horms@verge.net.au>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"hui.geng@huawei.com" <hui.geng@huawei.com>
Subject: Re: [RFC PATCH]: merge identical code
Date: Fri, 11 Apr 2014 10:36:47 +0800 [thread overview]
Message-ID: <5347553F.2080907@huawei.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE971FFF3A@BPXM01GP.gisp.nec.co.jp>
On 2014/4/10 15:56, Atsushi Kumagai wrote:
> Hello Wang,
>
>> Hi Kumagai,
>>
>> I found that in makedumpfile.c, there are many code like following:
>>
>> if (info->flag_cyclic) {
>> proc_cyclic();
>> } else {
>> proc();
>> }
>>
>> The logical and code of proc_cyclic and proc are nearly identical.
>>
>> Do you want to merge them together?
>
> Yes, I think we should do this work.
>
> However, the similarity of them will be reduced since how to update
> cyclic region is going to be changed in v1.5.6.
> If you can carry out this work also for v1.5.6, I'll accept it.
>
> You can use the current devel branch because it's almost v1.5.6.
> (Formally, v1.5.6 will be released next week.)
>
> https://sourceforge.net/p/makedumpfile/code/ci/devel/tree/
>
>
> Thanks
> Atsushi Kumagai
>
What about totaly remove non-cyclic functions and use a very large cyclic?
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-04-11 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 12:31 [RFC PATCH]: merge identical code Wang Nan
2014-04-10 7:56 ` Atsushi Kumagai
2014-04-11 2:36 ` Wang Nan [this message]
2014-04-11 6:30 ` Atsushi Kumagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5347553F.2080907@huawei.com \
--to=wangnan0@huawei.com \
--cc=horms@verge.net.au \
--cc=hui.geng@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox