From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from terminus.zytor.com ([2001:1868:205::10] helo=mail.zytor.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYRLb-0002rf-My for kexec@lists.infradead.org; Fri, 11 Apr 2014 02:37:43 +0000 Message-ID: <5347554A.4080009@zytor.com> Date: Thu, 10 Apr 2014 19:36:58 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH v5 09/10] x86: Pass memory range via E820 for kdump References: <1397121186-9353-1-git-send-email-chaowang@redhat.com> <1397121186-9353-14-git-send-email-chaowang@redhat.com> <20140411022831.GG5493@dhcp-16-198.nay.redhat.com> In-Reply-To: <20140411022831.GG5493@dhcp-16-198.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young , WANG Chao Cc: kexec@lists.infradead.org, horms@verge.net.au, linn@hp.com, trenn@suse.de, vgoyal@redhat.com, ebiederm@xmission.com On 04/10/2014 07:28 PM, Dave Young wrote: >> >> +static void add_e820_map_from_mr(struct x86_linux_param_header *real_mode, >> + struct e820entry *e820, struct memory_range *range, int nr_range) >> +{ >> + int i; >> + >> + for (i = 0; i < nr_range; i++) { >> + e820[i].addr = range[i].start; >> + e820[i].size = range[i].end - range[i].start; > > I see it's same as original code but I still feel it should be end - start + 1; > I can't see how it could possibly be +1. How do you encode range[].end? If it is inclusive it should be end - start - 1, if it is a semiclosed range (the normal thing in computer contexts) then the code above is correct. -hpa _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec