From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from e7.ny.us.ibm.com ([32.97.182.137]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOu2C-0003dt-U8 for kexec@lists.infradead.org; Tue, 02 Sep 2014 19:46:33 +0000 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Sep 2014 15:46:11 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id A0A8538C8026 for ; Tue, 2 Sep 2014 15:46:08 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s82Jk82n65929332 for ; Tue, 2 Sep 2014 19:46:08 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s82Jk6YQ013946 for ; Tue, 2 Sep 2014 15:46:07 -0400 Message-ID: <54061E7B.4080803@linux.vnet.ibm.com> Date: Tue, 02 Sep 2014 14:46:03 -0500 From: Brian King MIME-Version: 1.0 Subject: Re: [PATCH 2/5] kexec: Export kexec_in_progress References: <53D6B270.5020403@linux.vnet.ibm.com> <53DF96E5.7000601@linux.vnet.ibm.com> <54009E8A.4070809@linux.vnet.ibm.com> <87wq9piw59.fsf@x220.int.ebiederm.org> In-Reply-To: <87wq9piw59.fsf@x220.int.ebiederm.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Eric W. Biederman" Cc: kexec@lists.infradead.org, Wendy Xiong , linux-scsi , "James E.J. Bottomley" On 08/30/2014 03:02 PM, Eric W. Biederman wrote: > Brian King writes: > >> On 08/04/2014 09:21 AM, Brian King wrote: >>> On 07/28/2014 03:28 PM, Brian King wrote: >>>> >>>> Export kexec_in_progress for use by device drivers and other modules >>>> to optimize kexec boot. >>>> >>>> Signed-off-by: Brian King >>>> --- >>>> >>>> kernel/kexec.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff -puN kernel/kexec.c~kexec_export_in_prog kernel/kexec.c >>>> --- linux/kernel/kexec.c~kexec_export_in_prog 2014-07-23 17:05:24.851887935 -0500 >>>> +++ linux-bjking1/kernel/kexec.c 2014-07-23 17:05:24.856887970 -0500 >>>> @@ -1716,3 +1716,5 @@ int kernel_kexec(void) >>>> mutex_unlock(&kexec_mutex); >>>> return error; >>>> } >>>> + >>>> +EXPORT_SYMBOL_GPL(kexec_in_progress); >>> >>> Eric, >>> >>> Can I get an ack on this so we can take this entire series through the SCSI tree? >> >> Eric, >> >> Any issues with this patch? > > No huge issues except that patch description is largely uniformitive and > actually wrong. kexec_in_progress is never set at boot/kernel startup. Good point. How about this instead: Export kexec_in_progress for use by device drivers and other modules to optimize shutdown handling during kexec. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec