Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "HATAYAMA, Daisuke" <d.hatayama@jp.fujitsu.com>
To: "Wang, Xiao/Wang Xiao" <wangx.fnst@cn.fujitsu.com>
Cc: kexec@lists.infradead.org, Petr Tesarik <ptesarik@suse.cz>
Subject: Re: [PATCH 2/2] makedumpfile: make the incomplete vmcore generated by ENOSPC error analyzable
Date: Thu, 18 Sep 2014 20:18:29 +0900	[thread overview]
Message-ID: <541ABF85.5010100@jp.fujitsu.com> (raw)
In-Reply-To: <541A8932.30208@cn.fujitsu.com>

Hello Wang,

(2014/09/18 16:26), Wang, Xiao/Wang Xiao wrote:
> Hello Petr,
>
> Thanks for your reply.
>
> On 2014/9/17 14:47, Petr Tesarik wrote:
>>> Since the incomplete vmcore generated by ENOSPC error can't be anylyzed by
>>> >crash utility, but sometimes this file may contain important information
>> Hello 王萧,
>>
>> first of all, I like your patch. It has always annoyed me that any
>> incomplete dump was utterly useless. Just one small question: why is
>> this limited to ENOSPC? Why not e.g. EIO? EFBIG?
>
> At present, I just consider ENOSPC for this error maybe more common. And I'm
> considering to deal with other situations in the coming future.
>

For EFBIG, it seems to me enough to do the same thing as for ENOSPC fow now.

For EIO, although I'm not perfectly clear about when EIO is returned, but
such situation would include broken disk, and then we no longer trust disk
behaviour so we should stop makedumpfile from running as soon as possible,
and we should bet we can successfully recover the incomplete dump data
from the broken disk.

-- 
Thanks.
HATAYAMA, Daisuke


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-09-18 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16  9:48 [PATCH 2/2] makedumpfile: make the incomplete vmcore generated by ENOSPC error analyzable Wang, Xiao/Wang Xiao
2014-09-17  6:47 ` Petr Tesarik
2014-09-18  7:26   ` Wang, Xiao/Wang Xiao
2014-09-18 11:18     ` HATAYAMA, Daisuke [this message]
2014-09-18 12:29 ` HATAYAMA, Daisuke
2014-09-19  9:16   ` Wang, Xiao/Wang Xiao
2014-09-19  9:22     ` [PATCH 1/3] makedumpfile: make get_elf64_phdr()/get_elf32_phdr() public Wang, Xiao/Wang Xiao
     [not found] <mailman.12983.1410860958.22890.kexec@lists.infradead.org>
2014-09-16 13:20 ` [PATCH 2/2] makedumpfile: make the incomplete vmcore generated by ENOSPC error analyzable Dave Anderson
2014-09-17  2:41   ` Wang, Xiao/Wang Xiao
2014-09-17 13:55     ` Dave Anderson
2014-09-18  7:19       ` Wang, Xiao/Wang Xiao
2014-09-18 13:56         ` Dave Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541ABF85.5010100@jp.fujitsu.com \
    --to=d.hatayama@jp.fujitsu.com \
    --cc=kexec@lists.infradead.org \
    --cc=ptesarik@suse.cz \
    --cc=wangx.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox