From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKZvR-0002xF-2K for kexec@lists.infradead.org; Wed, 16 Oct 2019 03:24:38 +0000 Subject: Re: [PATCH 3/3 v3] x86/kdump: clean up all the code related to the backup region References: <20191012022140.19003-1-lijiang@redhat.com> <20191012022140.19003-4-lijiang@redhat.com> <87d0f22oi5.fsf@x220.int.ebiederm.org> <20191012121625.GA11587@dhcp-128-65.nay.redhat.com> <87tv8az2jq.fsf@x220.int.ebiederm.org> From: lijiang Message-ID: <54e8e316-1c7e-8d2e-270c-d5e178b46024@redhat.com> Date: Wed, 16 Oct 2019 11:24:16 +0800 MIME-Version: 1.0 In-Reply-To: <87tv8az2jq.fsf@x220.int.ebiederm.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Eric W. Biederman" Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, Dave Young , vgoyal@redhat.com 5ZyoIDIwMTnlubQxMOaciDE15pelIDE5OjExLCBFcmljIFcuIEJpZWRlcm1hbiDlhpnpgZM6Cj4g bGlqaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPiB3cml0ZXM6Cj4gCj4+IOWcqCAyMDE55bm0MTDm nIgxMuaXpSAyMDoxNiwgRGF2ZSBZb3VuZyDlhpnpgZM6Cj4+PiBIaSBFcmljLAo+Pj4KPj4+IE9u IDEwLzEyLzE5IGF0IDA2OjI2YW0sIEVyaWMgVy4gQmllZGVybWFuIHdyb3RlOgo+Pj4+IExpYW5i byBKaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPiB3cml0ZXM6Cj4+Pj4KPj4+Pj4gV2hlbiB0aGUg Y3Jhc2hrZXJuZWwga2VybmVsIGNvbW1hbmQgbGluZSBvcHRpb24gaXMgc3BlY2lmaWVkLCB0aGUK Pj4+Pj4gbG93IDFNaUIgbWVtb3J5IHdpbGwgYWx3YXlzIGJlIHJlc2VydmVkLCB3aGljaCBtYWtl cyB0aGF0IHRoZSBtZW1vcnkKPj4+Pj4gYWxsb2NhdGVkIGxhdGVyIHdvbid0IGZhbGwgaW50byB0 aGUgbG93IDFNaUIgYXJlYSwgdGhlcmVieSwgaXQncyBub3QKPj4+Pj4gbmVjZXNzYXJ5IHRvIGNy ZWF0ZSBhIGJhY2t1cCByZWdpb24gYW5kIGFsc28gbm8gbmVlZCB0byBjb3B5IHRoZSBmaXJzdAo+ Pj4+PiA2NDBrIGNvbnRlbnQgdG8gYSBiYWNrdXAgcmVnaW9uLgo+Pj4+Pgo+Pj4+PiBDdXJyZW50 bHksIHRoZSBjb2RlIHJlbGF0ZWQgdG8gdGhlIGJhY2t1cCByZWdpb24gY2FuIGJlIHNhZmVseSBy ZW1vdmVkLAo+Pj4+PiBzbyBsZXRzIGNsZWFuIHVwLgo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBMaWFuYm8gSmlhbmcgPGxpamlhbmdAcmVkaGF0LmNvbT4KPj4+Pj4gLS0tCj4+Pj4KPj4+Pj4g ZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jIGIvYXJjaC94ODYva2VybmVsL2Ny YXNoLmMKPj4+Pj4gaW5kZXggZWI2NTFmYmRlOTJhLi5jYzU3NzRmYzg0YzAgMTAwNjQ0Cj4+Pj4+ IC0tLSBhL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4+Pj4+ICsrKyBiL2FyY2gveDg2L2tlcm5l bC9jcmFzaC5jCj4+Pj4+IEBAIC0xNzMsOCArMTczLDYgQEAgdm9pZCBuYXRpdmVfbWFjaGluZV9j cmFzaF9zaHV0ZG93bihzdHJ1Y3QgcHRfcmVncyAqcmVncykKPj4+Pj4gIAo+Pj4+PiAgI2lmZGVm IENPTkZJR19LRVhFQ19GSUxFCj4+Pj4+ICAKPj4+Pj4gLXN0YXRpYyB1bnNpZ25lZCBsb25nIGNy YXNoX3plcm9fYnl0ZXM7Cj4+Pj4+IC0KPj4+Pj4gIHN0YXRpYyBpbnQgZ2V0X25yX3JhbV9yYW5n ZXNfY2FsbGJhY2soc3RydWN0IHJlc291cmNlICpyZXMsIHZvaWQgKmFyZykKPj4+Pj4gIHsKPj4+ Pj4gIAl1bnNpZ25lZCBpbnQgKm5yX3JhbmdlcyA9IGFyZzsKPj4+Pj4gQEAgLTIzNCw5ICsyMzIs MTUgQEAgc3RhdGljIGludCBwcmVwYXJlX2VsZjY0X3JhbV9oZWFkZXJzX2NhbGxiYWNrKHN0cnVj dCByZXNvdXJjZSAqcmVzLCB2b2lkICphcmcpCj4+Pj4+ICB7Cj4+Pj4+ICAJc3RydWN0IGNyYXNo X21lbSAqY21lbSA9IGFyZzsKPj4+Pj4gIAo+Pj4+PiAtCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9y YW5nZXNdLnN0YXJ0ID0gcmVzLT5zdGFydDsKPj4+Pj4gLQljbWVtLT5yYW5nZXNbY21lbS0+bnJf cmFuZ2VzXS5lbmQgPSByZXMtPmVuZDsKPj4+Pj4gLQljbWVtLT5ucl9yYW5nZXMrKzsKPj4+Pj4g KwlpZiAocmVzLT5zdGFydCA+PSBTWl8xTSkgewo+Pj4+PiArCQljbWVtLT5yYW5nZXNbY21lbS0+ bnJfcmFuZ2VzXS5zdGFydCA9IHJlcy0+c3RhcnQ7Cj4+Pj4+ICsJCWNtZW0tPnJhbmdlc1tjbWVt LT5ucl9yYW5nZXNdLmVuZCA9IHJlcy0+ZW5kOwo+Pj4+PiArCQljbWVtLT5ucl9yYW5nZXMrKzsK Pj4+Pj4gKwl9IGVsc2UgaWYgKHJlcy0+ZW5kID4gU1pfMU0pIHsKPj4+Pj4gKwkJY21lbS0+cmFu Z2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSBTWl8xTTsKPj4+Pj4gKwkJY21lbS0+cmFuZ2Vz W2NtZW0tPm5yX3Jhbmdlc10uZW5kID0gcmVzLT5lbmQ7Cj4+Pj4+ICsJCWNtZW0tPm5yX3Jhbmdl cysrOwo+Pj4+PiArCX0KPj4+Pgo+Pj4+IFdoYXQgaXMgZ29pbmcgb24gd2l0aCB0aGlzIGNodW5r PyAgSSBjYW4gZ3Vlc3MgYnV0IHRoaXMgbmVlZHMgYSBjbGVhcgo+Pj4+IGNvbW1lbnQuCj4+Pgo+ Pj4gSW5kZWVkIGl0IG5lZWRzIHNvbWUgY29kZSBjb21tZW50LCB0aGlzIGlzIGJhc2VkIG9uIHNv bWUgb2ZmbGluZQo+Pj4gZGlzY3Vzc2lvbi4gIGNhdCAvcHJvYy92bWNvcmUgd2lsbCBnaXZlIGEg d2FybmluZyBiZWNhdXNlIGlvcmVtYXAgaXMKPj4+IG1hcHBpbmcgdGhlIHN5c3RlbSByYW0uCj4+ Pgo+Pj4gV2UgcGFzcyB0aGUgZmlyc3QgMU0gdG8ga2R1bXAga2VybmVsIGluIGU4MjAgYXMgc3lz dGVtIHJhbSBzbyB0aGF0IDJuZAo+Pj4ga2VybmVsIGNhbiB1c2UgdGhlIGxvdyAxTSBtZW1vcnkg YmVjYXVzZSBmb3IgZXhhbXBsZSB0aGUgdHJhbXBvbGluZQo+Pj4gY29kZS4KPj4+Cj4+IFRoYW5r IHlvdSwgRXJpYyBhbmQgRGF2ZS4gSSB3aWxsIGFkZCB0aGUgY29kZSBjb21tZW50IGFzIGJlbG93 IGlmIGl0IHdvdWxkIGJlIE9LLgo+Pgo+PiBAQCAtMjM0LDkgKzIzMiwyMCBAQCBzdGF0aWMgaW50 IHByZXBhcmVfZWxmNjRfcmFtX2hlYWRlcnNfY2FsbGJhY2soc3RydWN0IHJlc291cmNlICpyZXMs IHZvaWQgKmFyZykKPj4gIHsKPj4gICAgICAgICBzdHJ1Y3QgY3Jhc2hfbWVtICpjbWVtID0gYXJn Owo+PiAgCj4+IC0gICAgICAgY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSBy ZXMtPnN0YXJ0Owo+PiAtICAgICAgIGNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLmVuZCA9 IHJlcy0+ZW5kOwo+PiAtICAgICAgIGNtZW0tPm5yX3JhbmdlcysrOwo+PiArICAgICAgIC8qCj4+ ICsgICAgICAgICogQ3VycmVudGx5LCBwYXNzIHRoZSBsb3cgMU1pQiByYW5nZSB0byBrZHVtcCBr ZXJuZWwgaW4gZTgyMAo+PiArICAgICAgICAqIGFzIHN5c3RlbSByYW0gc28gdGhhdCBrZHVtcCBr ZXJuZWwgY2FuIGFsc28gdXNlIHRoZSBsb3cgMU1pQgo+PiArICAgICAgICAqIG1lbW9yeSBkdWUg dG8gdGhlIHJlYWwgbW9kZSB0cmFtcG9saW5lIGNvZGUuCj4+ICsgICAgICAgICogQW5kIGxhdGVy LCB0aGUgbG93IDFNaUIgcmFuZ2Ugd2lsbCBiZSBleGNsdWVkIGZyb20gZWxmIGhlYWRlciwKPj4g KyAgICAgICAgKiB3aGljaCB3aWxsIGF2b2lkIHJlbWFwcGluZyB0aGUgMU1pQiBzeXN0ZW0gcmFt IHdoZW4gZHVtcGluZwo+PiArICAgICAgICAqIHZtY29yZS4KPj4gKyAgICAgICAgKi8KPj4gKyAg ICAgICBpZiAocmVzLT5zdGFydCA+PSBTWl8xTSkgewo+PiArICAgICAgICAgICAgICAgY21lbS0+ cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSByZXMtPnN0YXJ0Owo+PiArICAgICAgICAg ICAgICAgY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uZW5kID0gcmVzLT5lbmQ7Cj4+ICsg ICAgICAgICAgICAgICBjbWVtLT5ucl9yYW5nZXMrKzsKPj4gKyAgICAgICB9IGVsc2UgaWYgKHJl cy0+ZW5kID4gU1pfMU0pIHsKPj4gKyAgICAgICAgICAgICAgIGNtZW0tPnJhbmdlc1tjbWVtLT5u cl9yYW5nZXNdLnN0YXJ0ID0gU1pfMU07Cj4+ICsgICAgICAgICAgICAgICBjbWVtLT5yYW5nZXNb Y21lbS0+bnJfcmFuZ2VzXS5lbmQgPSByZXMtPmVuZDsKPj4gKyAgICAgICAgICAgICAgIGNtZW0t Pm5yX3JhbmdlcysrOwo+PiArICAgICAgIH0KPj4gIAo+PiAgICAgICAgIHJldHVybiAwOwo+PiAg fQo+IAo+IEkganVzdCByZWFkIHRocm91Z2ggdGhlIGFwcHJvcHJpYXRlIHNlY3Rpb24gb2YgY3Jh c2guYyBhbmQgdGhlIHdheQo+IHRoaW5ncyBhcmUgc3RydWN0dXJlZCBkb2luZyB0aGlzIHdvcmsg aW4KPiBwcmVwYXJlX2VsZjY0X3JhbV9oZWFkZXJzX2NhbGxiYWNrIGlzIHdyb25nLgo+IAo+IFRo aXMgY2FuIGJlIGRvbmUgaW4gYSBzaW1wbGVyIG1hbm5lciBpbiBlbGZfaGVhZGVyX2V4Y2x1ZGVf cmFuZ2VzLgo+IFNvbWV0aGluZyBsaWtlOgo+IApUaGFuayB5b3UsIEVyaWMuIEl0IHNlZW1zIHRo YXQgaGVyZSBpcyBhIG1vcmUgcmVhc29uYWJsZSBwbGFjZSwgaSB3aWxsIG1ha2UKYSB0ZXN0IGFi b3V0IGl0IGFuZCBpbXByb3ZlIGl0IGluIG5leHQgcG9zdC4KCkxpYW5ibwoKPiAJLyogVGhlIGxv dyAxTWlCIGlzIGFsd2F5cyByZXNlcnZlZCAqLwo+IAlyZXQgPSBjcmFzaF9leGNsdWRlX21lbV9y YW5nZShjbWVtLCAwLCAxMDI0KjEwMjQpOwo+IAlpZiAocmV0KQo+IAkJcmV0dXJuIHJldDsKPiAK PiBFcmljCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg==