From: Michele Dionisio <michele.dionisio@powersoft.it>
To: Pratyush Anand <panand@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] arm: ramdisk uimage support for arm
Date: Thu, 17 Dec 2015 08:57:14 +0100 [thread overview]
Message-ID: <56726ADA.1050403@powersoft.it> (raw)
In-Reply-To: <20151217042353.GC1525@dhcppc13.redhat.com>
yes it is true.
I'm not in the position to test ppc. So my only way to be sure to avoid
to introduce regration is to avoid to refactor the code.
But it is true. If you are able to test ppc I can try to post the
refactoring.
Il 17/12/2015 05:23, Pratyush Anand ha scritto:
> Hi Michele,
>
> On 16/12/2015:09:06:36 AM, Michele Dionisio wrote:
>> +/*
>> + * Load the ramdisk into buffer.
>> + * If the supplied image is in uImage format use
>> + * uImage_load() to read the payload from the image.
>> + */
>> +char *slurp_ramdisk_arm(const char *filename, off_t *r_size)
> This function is exactly as slurp_ramdisk_ppc(). So, why not we have a common
> slurp_ramdisk() function usable for both arm and ppc.
>
> ~Pratyush
> .
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-12-17 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 8:06 [PATCH] arm: ramdisk uimage support for arm Michele Dionisio
2015-12-17 4:23 ` Pratyush Anand
2015-12-17 7:57 ` Michele Dionisio [this message]
2015-12-17 9:51 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56726ADA.1050403@powersoft.it \
--to=michele.dionisio@powersoft.it \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox