From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com>
To: Minoru Usui <min-usui@ti.jp.nec.com>
Cc: Minfei Huang <mhuang@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH v3] Improve the performance of --num-threads -d 31
Date: Mon, 7 Mar 2016 16:43:19 +0800 [thread overview]
Message-ID: <56DD3F27.4030105@cn.fujitsu.com> (raw)
In-Reply-To: <56DD3A3E.1000402@cn.fujitsu.com>
Hi Minoru,
I got two error dumpfiles by running it less than 100 times.
--
Thanks
Zhou
On 03/07/2016 04:22 PM, "Zhou, Wenjian/周文?" wrote:
> Hi Minoru,
>
> I have test your patch since you post.
> I can get a failure easily.
> If you run it several times, the dumpfile it produces may be different from the correct one.
>
> + info->current_pfn = pfn + 1;
> + pthread_mutex_unlock(&info->current_pfn_mutex);
> + page_flag_buf->pfn = pfn;
> + page_flag_buf->ready = FLAG_FILLING;
> The above code should be changed to the following:
>
> + info->current_pfn = pfn + 1;
> + page_flag_buf->pfn = pfn;
> + page_flag_buf->ready = FLAG_FILLING;
> + pthread_mutex_unlock(&info->current_pfn_mutex);
>
> I haven't run your code with the bug fixed.
> I'll try now.
>
> By the way, with my patch v3, I can't get an error dumpfile until run it by 5000 times.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-03-07 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 8:35 [PATCH v3] Improve the performance of --num-threads -d 31 Zhou Wenjian
2016-03-04 9:07 ` "Zhou, Wenjian/周文剑"
2016-03-07 0:17 ` "Zhou, Wenjian/周文剑"
2016-03-07 5:53 ` Minfei Huang
2016-03-07 7:04 ` Minfei Huang
2016-03-07 7:36 ` Minoru Usui
2016-03-07 8:16 ` Minoru Usui
2016-03-07 8:39 ` Minfei Huang
2016-03-07 8:46 ` "Zhou, Wenjian/周文剑"
2016-03-07 8:22 ` "Zhou, Wenjian/周文?"
2016-03-07 8:43 ` "Zhou, Wenjian/周文剑" [this message]
2016-03-07 8:52 ` Minoru Usui
2016-03-07 9:03 ` "Zhou, Wenjian/周文剑"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD3F27.4030105@cn.fujitsu.com \
--to=zhouwj-fnst@cn.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=mhuang@redhat.com \
--cc=min-usui@ti.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox