From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cJXWk-0001u7-VM for kexec@lists.infradead.org; Wed, 21 Dec 2016 03:25:16 +0000 Subject: Re: [PATCHv2 2/2] [fs] proc/vmcore: check the dummy place holder for offline cpu to avoid warning References: <1482113327-19103-1-git-send-email-piliu@redhat.com> <1482113327-19103-2-git-send-email-piliu@redhat.com> <20161219024018.GB29921@dhcp-128-65.nay.redhat.com> <6691e874-e47a-0028-a2f8-59e431613d6f@redhat.com> From: Xunlei Pang Message-ID: <5859F65D.1060506@redhat.com> Date: Wed, 21 Dec 2016 11:26:21 +0800 MIME-Version: 1.0 In-Reply-To: <6691e874-e47a-0028-a2f8-59e431613d6f@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: xlpang@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pratyush Anand , Dave Young , Pingfan Liu Cc: kexec@lists.infradead.org, Baoquan He , kernelfans@gmail.com On 12/20/2016 at 11:38 PM, Pratyush Anand wrote: > > > On Monday 19 December 2016 08:10 AM, Dave Young wrote: >> Hi, Pingfan >> >> On 12/19/16 at 10:08am, Pingfan Liu wrote: >>> > kexec-tools always allocates program headers for present cpus. But >>> > when crashing, offline cpus have dummy headers. We do not copy these >>> > dummy notes into ELF file, also have no need of warning on them. >> I still think it is not worth such a fix, if you feel a lot of warnings >> in case large cpu numbers, I think you can change the pr_warn to >> pr_warn_once, we do not care the null cpu notes if it has nothing bad >> to the vmcore. >> > > I agree. Warning is more like information here. May be, we can count the number of times real_sz was 0, and then can print an info at the end in stead of warning, like..."N number of CPUs would have been offline, PT_NOTE entries was absent for them." Well, OTOH the warning may also be due to some user-space misuse, we can't distinguish that without extra information added. Another possible user-space fix would be: Firstly fix kexec-tools to add notes only for online cpus, then utilize udev rules(cpu online/offline events) to automatically trigger kdump kernel reload. Regards, Xunlei _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec