From: James Morse <james.morse@arm.com>
To: Pratyush Anand <panand@redhat.com>
Cc: mark.rutland@arm.com, bhe@redhat.com, kexec@lists.infradead.org,
horms@verge.net.au, dyoung@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory
Date: Fri, 02 Jun 2017 09:23:28 +0100 [thread overview]
Message-ID: <59312080.1090906@arm.com> (raw)
In-Reply-To: <cover.1495514291.git.panand@redhat.com>
Hi Pratyush,
On 23/05/17 06:02, Pratyush Anand wrote:
> It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image
> is around 13MB and initramfs is around 30MB. It takes more than 20 second
> even when we have -O2 optimization enabled. However, if dcache is enabled
> during purgatory execution then, it takes just a second in SHA
> verification.
>
> Therefore, these patches adds support for dcache enabling facility during
> purgatory execution.
I'm still not convinced we need this. Moving the SHA verification to happen
before the dcache+mmu are disabled would also solve the delay problem, and we
can print an error message or fail the syscall.
For kexec we don't expect memory corruption, what are we testing for?
I can see the use for kdump, but the kdump-kernel is unmapped so the kernel
can't accidentally write over it.
(we discussed all this last time, but it fizzled-out. If you and the
kexec-tools maintainer think its necessary, fine by me!)
I have some comments on making this code easier to maintain..
Thanks,
James
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-06-02 8:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 5:02 [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory Pratyush Anand
2017-05-23 5:02 ` [PATCH v3 1/2] kexec: arm64: create identity page table to be used " Pratyush Anand
2017-06-02 8:24 ` James Morse
2017-06-02 14:29 ` Pratyush Anand
2017-05-23 5:02 ` [PATCH v3 2/2] arm64: enable d-cache support during purgatory sha verification Pratyush Anand
2017-06-02 8:23 ` James Morse [this message]
2017-06-02 9:55 ` [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory Ard Biesheuvel
2017-06-02 11:15 ` Bhupesh SHARMA
2017-06-02 11:36 ` Ard Biesheuvel
2017-06-02 11:44 ` Ard Biesheuvel
2017-06-02 14:32 ` Pratyush Anand
2017-06-02 16:36 ` James Morse
2017-06-02 14:42 ` Pratyush Anand
[not found] ` <CAB=otbT23ySN4VC6G0sBKF5p4SvsnG8PS-C_beBgn8YJUsbw9Q@mail.gmail.com>
2018-04-04 12:45 ` Kostiantyn Iarmak
2018-04-04 13:04 ` Kostiantyn Iarmak
2018-04-04 13:28 ` James Morse
2018-04-04 22:55 ` Ard Biesheuvel
2018-04-05 1:47 ` AKASHI Takahiro
2018-04-06 18:15 ` Kostiantyn Iarmak
2018-04-11 15:59 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59312080.1090906@arm.com \
--to=james.morse@arm.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox