From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g3BAd-0003w8-HR for kexec@lists.infradead.org; Fri, 21 Sep 2018 02:27:53 +0000 Message-ID: <5BA4570F.6050700@huawei.com> Date: Fri, 21 Sep 2018 10:27:27 +0800 From: zhong jiang MIME-Version: 1.0 Subject: Re: [PATCH] kernel: kexec_file: remove some duplicated include file References: <1537420323-30658-1-git-send-email-zhongjiang@huawei.com> <20180921021524.GP2555@MiWiFi-R3L-srv> In-Reply-To: <20180921021524.GP2555@MiWiFi-R3L-srv> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Baoquan He Cc: kexec@lists.infradead.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org On 2018/9/21 10:15, Baoquan He wrote: > On 09/20/18 at 01:12pm, zhong jiang wrote: >> kexec.h and slab.h have duplicated include. hence just remove >> redundant file. > They have duplicated include, why do you remove both of them? because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary. Thanks, zhong jiang >> Signed-off-by: zhong jiang >> --- >> kernel/kexec_file.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c >> index c6a3b68..35cf0ad 100644 >> --- a/kernel/kexec_file.c >> +++ b/kernel/kexec_file.c >> @@ -25,8 +25,6 @@ >> #include >> #include >> #include >> -#include >> -#include >> #include >> #include >> #include "kexec_internal.h" >> -- >> 1.7.12.4 >> >> >> _______________________________________________ >> kexec mailing list >> kexec@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/kexec > . > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec