From: Eric DeVolder <eric.devolder@oracle.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: ats-kumagai@wm.jp.nec.com, kexec@lists.infradead.org,
konrad.wilk@oracle.com
Subject: Re: [makedumpfile PATCH] Wipe excluded pages that are written into ELF dump file
Date: Fri, 4 Aug 2017 05:19:27 -0700 [thread overview]
Message-ID: <5a750e32-2f26-93c9-43e5-e1e4a942ef2d@oracle.com> (raw)
In-Reply-To: <20170731175956.GE7443@olila.local.net-space.pl>
On 07/31/2017 10:59 AM, Daniel Kiper wrote:
> On Mon, Jul 31, 2017 at 06:35:30AM -0700, Eric DeVolder wrote:
[...snip...]
>> diff --git a/makedumpfile.h b/makedumpfile.h
>> index 8a05794..9ccd06d 100644
>> --- a/makedumpfile.h
>> +++ b/makedumpfile.h
>> @@ -1266,6 +1266,7 @@ struct DumpInfo {
>> int vmemmap_cnt;
>> struct ppc64_vmemmap *vmemmap_list;
>> unsigned long kaslr_offset;
>> + unsigned long fill_excluded_pages_value; /* fill value for excluded pages */
>>
>> /*
>> * page table info for ppc64
>> @@ -2275,6 +2276,7 @@ struct elf_prstatus {
>> #define OPT_WORKING_DIR OPT_START+15
>> #define OPT_NUM_THREADS OPT_START+16
>> #define OPT_PARTIAL_DMESG OPT_START+17
>> +#define OPT_FILL_EXCLUDED_PAGES OPT_START+18
>
> Oh, no please fix alignment somehow here. Separate patch?
> And I think that just in case it should be:
>
> #define OPT_FILL_EXCLUDED_PAGES (OPT_START+18)
>
> And probably this applies to others. Next patch?
I will fix formatting in a subsequent patch.
eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-08-04 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 13:35 [makedumpfile PATCH] Wipe excluded pages that are written into ELF dump file Eric DeVolder
2017-07-31 17:59 ` Daniel Kiper
2017-08-03 3:00 ` Atsushi Kumagai
2017-08-04 12:17 ` Eric DeVolder
2017-08-04 12:19 ` Eric DeVolder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a750e32-2f26-93c9-43e5-e1e4a942ef2d@oracle.com \
--to=eric.devolder@oracle.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=daniel.kiper@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox