Re: [PATCH] sysfs/cpu: Make crash_hotplug attribute world-readable

[Sourabh Jain <sourabhjain@linux.ibm.com>]

On 12/07/24 12:18, Petr Tesarik wrote:
> On Fri, 12 Jul 2024 12:01:29 +0530
> Sourabh Jain <sourabhjain@linux.ibm.com> wrote:
>
>> Hello Petr,
>>
>> On 12/07/24 11:51, Petr Tesařík wrote:
>>> On Fri, 12 Jul 2024 10:00:09 +0530
>>> Sourabh Jain <sourabhjain@linux.ibm.com> wrote:
>>>   
>>>> Hello Petr,
>>>>
>>>> Just want to mentioned few points about the commit message. No strong
>>>> opinion on changing the commit message.
>>>>
>>>> On 11/07/24 16:04, Petr Tesarik wrote:
>>>>> From: Petr Tesarik <ptesarik@suse.com>
>>>>>
>>>>> There is no reason to restrict access to this attribute, as it merely
>>>>> reports whether crash elfcorehdr is automatically updated on CPU hot
>>>>> plug/unplug and/or online/offline events.
>>>> Now, it is not just elfcorehdr; there could be multiple kexec segments
>>>> based on the architecture's needs.
>>>> For example, on PowerPC, it is elfcorehdr and FDT.
>>> Right. I am even working with a PowerVM LPAR on an L922 system now. ;-)
>>>
>>> OTOH I was just too lazy to invent my own description, so I took it
>>> from Documentation/ABI/testing/sysfs-devices-system-cpu. That one
>>> could be improved. And a couple of other places... Expect a patch.
>> Thanks for point it out, I will send a patch to fix the ABI document for
>> crash_hotplug and other places in the kernel. Thanks,
> Oh, I was planning to do that, but if you want to send a patch
> yourself, I won't duplicate efforts. There are other cleanups on my
> TODO list.

Yes, I will take care of this.

Thanks,
Sourabh Jain

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec